diff options
author | Vladimir Oltean <vladimir.oltean@nxp.com> | 2021-09-27 14:21:41 +0300 |
---|---|---|
committer | Ramon Fried <rfried.dev@gmail.com> | 2021-09-28 18:50:56 +0300 |
commit | fca315a38202960cfbb4c5a8f3ff5e0860e630cb (patch) | |
tree | cbddb4535ca1086a85771a9453ee9d18a05697ea /board/gdsys | |
parent | bc4e98282eaee0d7870476ac78d9e534c4d6c59f (diff) | |
download | u-boot-fca315a38202960cfbb4c5a8f3ff5e0860e630cb.tar.xz |
arch: powerpc: mpc85xx: ensure mdiodev->name is NULL terminated after MDIO_NAME_LEN truncation
strncpy() simply bails out when copying a source string whose size
exceeds the destination string size, potentially leaving the destination
string unterminated.
One possible way to address is to pass MDIO_NAME_LEN - 1 and a
previously zero-initialized destination string, but this is more
difficult to maintain.
The chosen alternative is to use strlcpy(), which properly limits the
copy len in the (srclen >= size) case to "size - 1", and which is also
more efficient than the strncpy() byte-by-byte implementation by using
memcpy. The destination string returned by strlcpy() is always NULL
terminated.
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Reviewed-by: Ramon Fried <rfried.dev@gmail.com>
Diffstat (limited to 'board/gdsys')
0 files changed, 0 insertions, 0 deletions