diff options
| author | Masahiro Yamada <masahiroy@kernel.org> | 2020-06-26 09:13:33 +0300 |
|---|---|---|
| committer | Tom Rini <trini@konsulko.com> | 2020-07-17 16:30:13 +0300 |
| commit | b75d8dc5642b71eb029e7cd38031a32029e736cc (patch) | |
| tree | e13a2c309a27c528a79f7c49b468c0c2d246a499 /board/imgtec | |
| parent | 02ff91e8c60f1f48bee8f4bd1c87ea0892cc5dae (diff) | |
| download | u-boot-b75d8dc5642b71eb029e7cd38031a32029e736cc.tar.xz | |
treewide: convert bd_t to struct bd_info by coccinelle
The Linux coding style guide (Documentation/process/coding-style.rst)
clearly says:
It's a **mistake** to use typedef for structures and pointers.
Besides, using typedef for structures is annoying when you try to make
headers self-contained.
Let's say you have the following function declaration in a header:
void foo(bd_t *bd);
This is not self-contained since bd_t is not defined.
To tell the compiler what 'bd_t' is, you need to include <asm/u-boot.h>
#include <asm/u-boot.h>
void foo(bd_t *bd);
Then, the include direcective pulls in more bloat needlessly.
If you use 'struct bd_info' instead, it is enough to put a forward
declaration as follows:
struct bd_info;
void foo(struct bd_info *bd);
Right, typedef'ing bd_t is a mistake.
I used coccinelle to generate this commit.
The semantic patch that makes this change is as follows:
<smpl>
@@
typedef bd_t;
@@
-bd_t
+struct bd_info
</smpl>
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Diffstat (limited to 'board/imgtec')
| -rw-r--r-- | board/imgtec/boston/dt.c | 2 | ||||
| -rw-r--r-- | board/imgtec/ci20/ci20.c | 4 | ||||
| -rw-r--r-- | board/imgtec/malta/malta.c | 2 |
3 files changed, 4 insertions, 4 deletions
diff --git a/board/imgtec/boston/dt.c b/board/imgtec/boston/dt.c index c7ae90418f..44b56416ff 100644 --- a/board/imgtec/boston/dt.c +++ b/board/imgtec/boston/dt.c @@ -6,7 +6,7 @@ #include <common.h> #include <fdt_support.h> -int ft_board_setup(void *blob, bd_t *bd) +int ft_board_setup(void *blob, struct bd_info *bd) { DECLARE_GLOBAL_DATA_PTR; u64 mem_start[2], mem_size[2]; diff --git a/board/imgtec/ci20/ci20.c b/board/imgtec/ci20/ci20.c index 5339b9e9f9..038dbdd74f 100644 --- a/board/imgtec/ci20/ci20.c +++ b/board/imgtec/ci20/ci20.c @@ -195,7 +195,7 @@ int misc_init_r(void) } #ifdef CONFIG_DRIVER_DM9000 -int board_eth_init(bd_t *bis) +int board_eth_init(struct bd_info *bis) { /* Enable clock */ jz4780_clk_ungate_ethernet(); @@ -254,7 +254,7 @@ int checkboard(void) #ifdef CONFIG_SPL_BUILD #if defined(CONFIG_SPL_MMC_SUPPORT) -int board_mmc_init(bd_t *bd) +int board_mmc_init(struct bd_info *bd) { ci20_mux_mmc(); return jz_mmc_init((void __iomem *)MSC0_BASE); diff --git a/board/imgtec/malta/malta.c b/board/imgtec/malta/malta.c index 88a1a63bf4..252cc813c6 100644 --- a/board/imgtec/malta/malta.c +++ b/board/imgtec/malta/malta.c @@ -119,7 +119,7 @@ int checkboard(void) return 0; } -int board_eth_init(bd_t *bis) +int board_eth_init(struct bd_info *bis) { return pci_eth_init(bis); } |