summaryrefslogtreecommitdiff
path: root/board/wandboard
diff options
context:
space:
mode:
authorSimon Glass <sjg@chromium.org>2020-05-10 20:39:55 +0300
committerTom Rini <trini@konsulko.com>2020-05-18 21:54:24 +0300
commitc3dc39a2f85b16bf590789f7e283cd72275cd168 (patch)
treefd07b448aa4192e1d4fede43e412d5fdfa584b82 /board/wandboard
parentb79fdc76978515fba2c4f3b5b4f2e679c5ff1463 (diff)
downloadu-boot-c3dc39a2f85b16bf590789f7e283cd72275cd168.tar.xz
arm: Don't include common.h in header files
It is bad practice to include common.h in other header files since it can bring in any number of superfluous definitions. It implies that some C files don't include it and thus may be missing CONFIG options that are set up by that file. The C files should include these themselves. Update some header files in arch/arm to drop this. Signed-off-by: Simon Glass <sjg@chromium.org>
Diffstat (limited to 'board/wandboard')
-rw-r--r--board/wandboard/spl.c1
-rw-r--r--board/wandboard/wandboard.c1
2 files changed, 2 insertions, 0 deletions
diff --git a/board/wandboard/spl.c b/board/wandboard/spl.c
index dbd9d0286f..250043a26d 100644
--- a/board/wandboard/spl.c
+++ b/board/wandboard/spl.c
@@ -5,6 +5,7 @@
* Richard Hu <hakahu@gmail.com>
*/
+#include <common.h>
#include <asm/arch/clock.h>
#include <asm/arch/imx-regs.h>
#include <asm/arch/iomux.h>
diff --git a/board/wandboard/wandboard.c b/board/wandboard/wandboard.c
index fb2f3c1fd2..9705a1d8e3 100644
--- a/board/wandboard/wandboard.c
+++ b/board/wandboard/wandboard.c
@@ -6,6 +6,7 @@
* Author: Fabio Estevam <fabio.estevam@freescale.com>
*/
+#include <common.h>
#include <init.h>
#include <asm/arch/clock.h>
#include <asm/arch/crm_regs.h>