diff options
| author | Michal Simek <michal.simek@amd.com> | 2023-06-01 13:32:36 +0300 |
|---|---|---|
| committer | Michal Simek <michal.simek@amd.com> | 2023-06-12 14:25:01 +0300 |
| commit | 999ac2c37ae12df4e889a968056d409c55d38cd7 (patch) | |
| tree | 16f6662fc810cc7ef9821081581f0768e42b577c /board/xilinx | |
| parent | 24d32e05cec97db33bfc9c647730e1627982bae7 (diff) | |
| download | u-boot-999ac2c37ae12df4e889a968056d409c55d38cd7.tar.xz | |
arm64: zynqmp: Check 0 node ID
ID is decimal not hexadecimal that's why passing hex number all the time
end's up as 0 that's why check it. Node ID 0 is not valid anyway.
Also properly say it in help.
Signed-off-by: Michal Simek <michal.simek@amd.com>
Link: https://lore.kernel.org/r/68c5cd5eade216f3c5aa6eb703ee9f69f14acad1.1685615549.git.michal.simek@amd.com
Diffstat (limited to 'board/xilinx')
| -rw-r--r-- | board/xilinx/zynqmp/cmds.c | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/board/xilinx/zynqmp/cmds.c b/board/xilinx/zynqmp/cmds.c index e20030ecda..c1224bdf82 100644 --- a/board/xilinx/zynqmp/cmds.c +++ b/board/xilinx/zynqmp/cmds.c @@ -216,6 +216,10 @@ static int do_zynqmp_pmufw(struct cmd_tbl *cmdtp, int flag, int argc, return zynqmp_pmufw_config_close(); id = dectoul(argv[3], NULL); + if (!id) { + printf("Incorrect ID passed\n"); + return CMD_RET_USAGE; + } printf("Enable permission for node ID %d\n", id); @@ -429,7 +433,7 @@ static char zynqmp_help_text[] = " lock(0)/split(1)\n" #endif "zynqmp pmufw address size - load PMU FW configuration object\n" - "zynqmp pmufw node <id> - load PMU FW configuration object\n" + "zynqmp pmufw node <id> - load PMU FW configuration object, <id> in dec\n" "zynqmp pmufw node close - disable config object loading\n" " node: keyword, id: NODE_ID in decimal format\n" "zynqmp rsa srcaddr srclen mod exp rsaop -\n" |