diff options
| author | Heinrich Schuchardt <heinrich.schuchardt@canonical.com> | 2022-12-31 02:49:10 +0300 |
|---|---|---|
| committer | Heinrich Schuchardt <heinrich.schuchardt@canonical.com> | 2023-01-04 15:17:42 +0300 |
| commit | 532952f63cfa708a04aba837f68ffe321489cdef (patch) | |
| tree | 7dda1011fe4e648d4353ead50321dbf41ac11340 /cmd | |
| parent | 582e3c9fb2337c2f49faa73ac86dde25f4d56901 (diff) | |
| download | u-boot-532952f63cfa708a04aba837f68ffe321489cdef.tar.xz | |
cmd: avoid endless loop in sound play command
A parameter starting with a hyphen leads to an endless loop in the sound
play command.
Leave it to dectoul() to handle the hyphen. It will return 0 for a negative
number.
Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
Diffstat (limited to 'cmd')
| -rw-r--r-- | cmd/sound.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/cmd/sound.c b/cmd/sound.c index cef71be5e3..0b7f959971 100644 --- a/cmd/sound.c +++ b/cmd/sound.c @@ -48,12 +48,12 @@ static int do_play(struct cmd_tbl *cmdtp, int flag, int argc, ++argv; while (argc || first) { first = false; - if (argc && *argv[0] != '-') { + if (argc) { msec = dectoul(argv[0], NULL); --argc; ++argv; } - if (argc && *argv[0] != '-') { + if (argc) { freq = dectoul(argv[0], NULL); --argc; ++argv; |