diff options
| author | Alexandru Gagniuc <mr.nuke.me@gmail.com> | 2021-01-20 19:46:52 +0300 |
|---|---|---|
| committer | Tom Rini <trini@konsulko.com> | 2021-02-18 03:46:43 +0300 |
| commit | e4928270a4ab758ecfe54c9b296a00470fdee335 (patch) | |
| tree | deb27616ae4940b79a1248df4fe65608e599d90e /common | |
| parent | 3dc2079733bba47ad1b72041010edab328bdcef6 (diff) | |
| download | u-boot-e4928270a4ab758ecfe54c9b296a00470fdee335.tar.xz | |
spl: fit: Remove useless loop in spl_fit_get_image_name()
When a desired configuration is not found, conf_node will have a
negative value. Thus the for loop will start at the root "/" node of
the image, print the "/description" property, and stop.
It appears the intent of the loop was to print the names of the
subnodes under "/configurations". We would need the offset to the
"/configurations" node, which is abstracted by fit_find_config_node().
This change agrees that abstracting the node offset is the correct
design, and we shouldn't be parsing the configurations manually. Thus
the loop in spl_fit_get_image_name() is useless. Remove it.
Signed-off-by: Alexandru Gagniuc <mr.nuke.me@gmail.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
Diffstat (limited to 'common')
| -rw-r--r-- | common/spl/spl_fit.c | 12 |
1 files changed, 1 insertions, 11 deletions
diff --git a/common/spl/spl_fit.c b/common/spl/spl_fit.c index 6fad7361bd..78d25e160e 100644 --- a/common/spl/spl_fit.c +++ b/common/spl/spl_fit.c @@ -89,18 +89,8 @@ static int spl_fit_get_image_name(const struct spl_fit_info *ctx, bool found = true; conf_node = fit_find_config_node(ctx->fit); - if (conf_node < 0) { -#ifdef CONFIG_SPL_LIBCOMMON_SUPPORT - printf("No matching DT out of these options:\n"); - for (node = fdt_first_subnode(ctx->fit, conf_node); - node >= 0; - node = fdt_next_subnode(ctx->fit, node)) { - name = fdt_getprop(ctx->fit, node, "description", &len); - printf(" %s\n", name); - } -#endif + if (conf_node < 0) return conf_node; - } name = fdt_getprop(ctx->fit, conf_node, type, &len); if (!name) { |