summaryrefslogtreecommitdiff
path: root/drivers/i2c
diff options
context:
space:
mode:
authorSai Pavan Boddu <sai.pavan.boddu@xilinx.com>2022-03-01 11:16:51 +0300
committerMichal Simek <michal.simek@xilinx.com>2022-03-09 14:36:37 +0300
commit94b3f3fc7d5eece585a688061fa7a32a1a1c8495 (patch)
treecbcc9fdcde0562c7b70f01a0a351b7389073e999 /drivers/i2c
parent1bc2a79a4cde5f703b33342f2fcea8af208614ed (diff)
downloadu-boot-94b3f3fc7d5eece585a688061fa7a32a1a1c8495.tar.xz
i2c: i2c-cdns: Fix write transaction state
Start write transfer after loading data to FIFO. Signed-off-by: Sai Pavan Boddu <sai.pavan.boddu@xilinx.com> Reviewed-by: Ashok Reddy Soma <ashok.reddy.soma@xilinx.com> Signed-off-by: Michal Simek <michal.simek@xilinx.com> Link: https://lore.kernel.org/r/f0b3e443daa7758e00dfdcc245cf6b2120b0e907.1646122610.git.michal.simek@xilinx.com
Diffstat (limited to 'drivers/i2c')
-rw-r--r--drivers/i2c/i2c-cdns.c6
1 files changed, 6 insertions, 0 deletions
diff --git a/drivers/i2c/i2c-cdns.c b/drivers/i2c/i2c-cdns.c
index 5736afb451..07d53be11f 100644
--- a/drivers/i2c/i2c-cdns.c
+++ b/drivers/i2c/i2c-cdns.c
@@ -251,6 +251,7 @@ static int cdns_i2c_write_data(struct i2c_cdns_bus *i2c_bus, u32 addr, u8 *data,
u8 *cur_data = data;
struct cdns_i2c_regs *regs = i2c_bus->regs;
u32 ret;
+ bool start = 1;
/* Set the controller in Master transmit mode and clear FIFO */
setbits_le32(&regs->control, CDNS_I2C_CONTROL_CLR_FIFO);
@@ -269,6 +270,11 @@ static int cdns_i2c_write_data(struct i2c_cdns_bus *i2c_bus, u32 addr, u8 *data,
while (len-- && !is_arbitration_lost(regs)) {
writel(*(cur_data++), &regs->data);
+ /* Trigger write only after loading data */
+ if (start) {
+ writel(addr, &regs->address);
+ start = 0;
+ }
if (len && readl(&regs->transfer_size) == CDNS_I2C_FIFO_DEPTH) {
ret = cdns_i2c_wait(regs, CDNS_I2C_INTERRUPT_COMP |
CDNS_I2C_INTERRUPT_ARBLOST);