diff options
| author | Michal Suchanek <msuchanek@suse.de> | 2022-10-12 22:58:08 +0300 |
|---|---|---|
| committer | Simon Glass <sjg@chromium.org> | 2022-10-29 16:36:33 +0300 |
| commit | 4954937d922840c212b7eba297cc2d4779f087ad (patch) | |
| tree | 7176fea63bf97553b10dbc57b225886476f81309 /drivers/w1 | |
| parent | aa5511e77b8bd8f943c66b6403896d06083b1d92 (diff) | |
| download | u-boot-4954937d922840c212b7eba297cc2d4779f087ad.tar.xz | |
dm: treewide: Do not use the return value of simple uclass iterator
uclass_first_device/uclass_next_device return value will be removed,
don't use it.
With the current implementation dev is equivalent to !ret. It is
redundant to check both, ret check can be replaced with dev check, and
ret check inside the iteration is dead code.
Signed-off-by: Michal Suchanek <msuchanek@suse.de>
Reviewed-by: Simon Glass <sjg@chromium.org>
Diffstat (limited to 'drivers/w1')
| -rw-r--r-- | drivers/w1/w1-uclass.c | 9 |
1 files changed, 2 insertions, 7 deletions
diff --git a/drivers/w1/w1-uclass.c b/drivers/w1/w1-uclass.c index de4f25bcf9..a4247ecd62 100644 --- a/drivers/w1/w1-uclass.c +++ b/drivers/w1/w1-uclass.c @@ -36,15 +36,10 @@ int w1_bus_find_dev(const struct udevice *bus, u64 id, struct udevice { struct udevice *dev; u8 family = id & 0xff; - int ret; - for (ret = uclass_first_device(UCLASS_W1_EEPROM, &dev); - !ret && dev; + for (uclass_first_device(UCLASS_W1_EEPROM, &dev); + dev; uclass_next_device(&dev)) { - if (ret || !dev) { - debug("cannot find w1 eeprom dev\n"); - return -ENODEV; - } if (dev_get_driver_data(dev) == family) { *devp = dev; |