diff options
| author | Simon Glass <sjg@chromium.org> | 2020-05-10 20:39:55 +0300 |
|---|---|---|
| committer | Tom Rini <trini@konsulko.com> | 2020-05-18 21:54:24 +0300 |
| commit | c3dc39a2f85b16bf590789f7e283cd72275cd168 (patch) | |
| tree | fd07b448aa4192e1d4fede43e412d5fdfa584b82 /include/net.h | |
| parent | b79fdc76978515fba2c4f3b5b4f2e679c5ff1463 (diff) | |
| download | u-boot-c3dc39a2f85b16bf590789f7e283cd72275cd168.tar.xz | |
arm: Don't include common.h in header files
It is bad practice to include common.h in other header files since it can
bring in any number of superfluous definitions. It implies that some C
files don't include it and thus may be missing CONFIG options that are set
up by that file. The C files should include these themselves.
Update some header files in arch/arm to drop this.
Signed-off-by: Simon Glass <sjg@chromium.org>
Diffstat (limited to 'include/net.h')
| -rw-r--r-- | include/net.h | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/include/net.h b/include/net.h index 82500eeb30..774ae2de63 100644 --- a/include/net.h +++ b/include/net.h @@ -15,9 +15,13 @@ #include <asm/cache.h> #include <asm/byteorder.h> /* for nton* / ntoh* stuff */ #include <env.h> +#include <log.h> +#include <time.h> #include <linux/if_ether.h> #include <rand.h> +struct cmd_tbl_s; + #define DEBUG_LL_STATE 0 /* Link local state machine changes */ #define DEBUG_DEV_PKT 0 /* Packets or info directed to the device */ #define DEBUG_NET_PKT 0 /* Packets on info on the network at large */ @@ -59,7 +63,7 @@ struct in_addr { * @argv: List of arguments * @return result (see enum command_ret_t) */ -int do_tftpb(cmd_tbl_t *cmdtp, int flag, int argc, char *const argv[]); +int do_tftpb(struct cmd_tbl_s *cmdtp, int flag, int argc, char *const argv[]); /** * An incoming packet handler. |