summaryrefslogtreecommitdiff
path: root/lib/efi_loader/efi_gop.c
diff options
context:
space:
mode:
authorHeinrich Schuchardt <xypron.glpk@gmx.de>2017-11-26 16:05:23 +0300
committerAlexander Graf <agraf@suse.de>2017-12-01 15:41:01 +0300
commit44549d62c31dc433366b4c5d6e58e0e3091e542b (patch)
treefd6e03452db855dcb3ac028fded769a2917d3393 /lib/efi_loader/efi_gop.c
parentea54ad59286efe7e600f3e189036fa96989eace4 (diff)
downloadu-boot-44549d62c31dc433366b4c5d6e58e0e3091e542b.tar.xz
efi_loader: helper function to add EFI object to list
To avoid duplicate coding provide a helper function that initializes an EFI object and adds it to the EFI object list. efi_exit() is the only place where we dereference a handle to obtain a protocol interface. Add a comment to the function. Suggested-by: Alexander Graf <agraf@suse.de> Reviewed-by: Simon Glass <sjg@chromium.org> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> Signed-off-by: Alexander Graf <agraf@suse.de>
Diffstat (limited to 'lib/efi_loader/efi_gop.c')
-rw-r--r--lib/efi_loader/efi_gop.c4
1 files changed, 1 insertions, 3 deletions
diff --git a/lib/efi_loader/efi_gop.c b/lib/efi_loader/efi_gop.c
index 498184d754..3caddd5f84 100644
--- a/lib/efi_loader/efi_gop.c
+++ b/lib/efi_loader/efi_gop.c
@@ -180,11 +180,9 @@ int efi_gop_register(void)
}
/* Hook up to the device list */
- INIT_LIST_HEAD(&gopobj->parent.protocols);
- list_add_tail(&gopobj->parent.link, &efi_obj_list);
+ efi_add_handle(&gopobj->parent);
/* Fill in object data */
- gopobj->parent.handle = &gopobj->ops;
ret = efi_add_protocol(gopobj->parent.handle, &efi_gop_guid,
&gopobj->ops);
if (ret != EFI_SUCCESS) {