summaryrefslogtreecommitdiff
path: root/lib
diff options
context:
space:
mode:
authorMasahiro Yamada <yamada.masahiro@socionext.com>2018-01-28 12:41:23 +0300
committerTom Rini <trini@konsulko.com>2018-01-29 20:50:13 +0300
commit1414e09b4f25f2ad5886f124024e10878feb75f0 (patch)
tree97a11f12e3df4c986547e65c73db24ef56ddc716 /lib
parentf39bfec230828a843bb53d0213709d47db1574df (diff)
downloadu-boot-1414e09b4f25f2ad5886f124024e10878feb75f0.tar.xz
kconfig: revert change that was not needed for -Wformat-security
Recent GCC versions warn if the format string is not a literal because the compiler cannot check the argument validity at compile time. Commit 192bc6948b02 ("Fix GCC format-security errors and convert sprintfs.") blindly replaced sprintf() with strcpy(), including many cases where the format parameter is a string literal. For the kconfig change: sprintf(header, " "); ..., here the format parameter is a string literal " ", so it is definitely equivalent to: strcpy(header, " "); Of course, if the 'header' did not have enough length for containing " ", it would be a security problem, but another problem. (in this case, the 'header' is 4 byte length buffer, so it is not a problem at all.) The kconfig code is kept as synced with Linux as possible, but this change made the code out-of-sync for nothing. Just reverting. Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Diffstat (limited to 'lib')
0 files changed, 0 insertions, 0 deletions