diff options
author | Simon Glass <sjg@chromium.org> | 2020-05-10 21:52:45 +0300 |
---|---|---|
committer | Tom Rini <trini@konsulko.com> | 2020-05-19 21:01:47 +0300 |
commit | f91f366bd56ef290b7b1f24a40a8be02c148d6d9 (patch) | |
tree | d7c6b993a6fd5f5a4dea7731855baabde6ff16b1 /test/dm/eth.c | |
parent | d934b43a0294148267c88f22d47aa2ebd77512a5 (diff) | |
download | u-boot-f91f366bd56ef290b7b1f24a40a8be02c148d6d9.tar.xz |
test: Use ut_asserteq_mem() where possible
Quite a few tests still use ut_assertok(memcmp(...)) and variants. Modify
them to use the macro designed for this purpose.
Suggested-by: Wolfgang Wallner <wolfgang.wallner@br-automation.com>
Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Wolfgang Wallner <wolfgang.wallner@br-automation.com>
Diffstat (limited to 'test/dm/eth.c')
-rw-r--r-- | test/dm/eth.c | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/test/dm/eth.c b/test/dm/eth.c index 99c1672b99..1fddcaabb0 100644 --- a/test/dm/eth.c +++ b/test/dm/eth.c @@ -282,17 +282,17 @@ static int sb_check_arp_reply(struct udevice *dev, void *packet, ut_assert(arp_is_waiting()); /* Validate response */ - ut_assert(memcmp(eth->et_src, net_ethaddr, ARP_HLEN) == 0); - ut_assert(memcmp(eth->et_dest, priv->fake_host_hwaddr, ARP_HLEN) == 0); + ut_asserteq_mem(eth->et_src, net_ethaddr, ARP_HLEN); + ut_asserteq_mem(eth->et_dest, priv->fake_host_hwaddr, ARP_HLEN); ut_assert(eth->et_protlen == htons(PROT_ARP)); ut_assert(arp->ar_hrd == htons(ARP_ETHER)); ut_assert(arp->ar_pro == htons(PROT_IP)); ut_assert(arp->ar_hln == ARP_HLEN); ut_assert(arp->ar_pln == ARP_PLEN); - ut_assert(memcmp(&arp->ar_sha, net_ethaddr, ARP_HLEN) == 0); + ut_asserteq_mem(&arp->ar_sha, net_ethaddr, ARP_HLEN); ut_assert(net_read_ip(&arp->ar_spa).s_addr == net_ip.s_addr); - ut_assert(memcmp(&arp->ar_tha, priv->fake_host_hwaddr, ARP_HLEN) == 0); + ut_asserteq_mem(&arp->ar_tha, priv->fake_host_hwaddr, ARP_HLEN); ut_assert(net_read_ip(&arp->ar_tpa).s_addr == string_to_ip("1.1.2.4").s_addr); @@ -373,8 +373,8 @@ static int sb_check_ping_reply(struct udevice *dev, void *packet, ut_assert(arp_is_waiting()); /* Validate response */ - ut_assert(memcmp(eth->et_src, net_ethaddr, ARP_HLEN) == 0); - ut_assert(memcmp(eth->et_dest, priv->fake_host_hwaddr, ARP_HLEN) == 0); + ut_asserteq_mem(eth->et_src, net_ethaddr, ARP_HLEN); + ut_asserteq_mem(eth->et_dest, priv->fake_host_hwaddr, ARP_HLEN); ut_assert(eth->et_protlen == htons(PROT_IP)); ut_assert(net_read_ip(&ip->ip_src).s_addr == net_ip.s_addr); |