diff options
| author | Simon Glass <sjg@chromium.org> | 2023-07-20 02:49:25 +0300 |
|---|---|---|
| committer | Simon Glass <sjg@chromium.org> | 2023-07-24 18:34:11 +0300 |
| commit | 57686d33795688d9e3ca9e4eae264246a2e395a0 (patch) | |
| tree | 6ccabc6bafb26562d68ac49134c96009393d0ba7 /tools/buildman | |
| parent | 5e5044b04c88c7889303ac1e8e9b48d17af903e2 (diff) | |
| download | u-boot-57686d33795688d9e3ca9e4eae264246a2e395a0.tar.xz | |
buildman: Tidy up reporting of a toolchain error
Provide the text of the exception when something goes wrong.
Signed-off-by: Simon Glass <sjg@chromium.org>
Diffstat (limited to 'tools/buildman')
| -rw-r--r-- | tools/buildman/builderthread.py | 7 | ||||
| -rw-r--r-- | tools/buildman/func_test.py | 6 |
2 files changed, 5 insertions, 8 deletions
diff --git a/tools/buildman/builderthread.py b/tools/buildman/builderthread.py index d3912390bc..043e92b6d9 100644 --- a/tools/buildman/builderthread.py +++ b/tools/buildman/builderthread.py @@ -457,18 +457,13 @@ class BuilderThread(threading.Thread): except ValueError as err: result.return_code = 10 result.stdout = '' - result.stderr = str(err) - # TODO(sjg@chromium.org): This gets swallowed, but needs - # to be reported. + result.stderr = f'Tool chain error for {brd.arch}: {str(err)}' if self.toolchain: commit = self._checkout(commit_upto, work_dir) result, do_config = self._config_and_build( commit_upto, brd, work_dir, do_config, config_only, adjust_cfg, commit, out_dir, out_rel_dir, result) - else: - result.return_code = 1 - result.stderr = f'No tool chain for {brd.arch}\n' result.already_done = False result.toolchain = self.toolchain diff --git a/tools/buildman/func_test.py b/tools/buildman/func_test.py index 07b4ac0174..126ea9e11f 100644 --- a/tools/buildman/func_test.py +++ b/tools/buildman/func_test.py @@ -511,8 +511,10 @@ Some images are invalid''' if brd.arch != 'sandbox': errfile = self._builder.get_err_file(commit, brd.target) fd = open(errfile) - self.assertEqual(fd.readlines(), - ['No tool chain for %s\n' % brd.arch]) + self.assertEqual( + fd.readlines(), + [f'Tool chain error for {brd.arch}: ' + f"No tool chain found for arch '{brd.arch}'"]) fd.close() def testBranch(self): |