From b75d8dc5642b71eb029e7cd38031a32029e736cc Mon Sep 17 00:00:00 2001 From: Masahiro Yamada Date: Fri, 26 Jun 2020 15:13:33 +0900 Subject: treewide: convert bd_t to struct bd_info by coccinelle The Linux coding style guide (Documentation/process/coding-style.rst) clearly says: It's a **mistake** to use typedef for structures and pointers. Besides, using typedef for structures is annoying when you try to make headers self-contained. Let's say you have the following function declaration in a header: void foo(bd_t *bd); This is not self-contained since bd_t is not defined. To tell the compiler what 'bd_t' is, you need to include #include void foo(bd_t *bd); Then, the include direcective pulls in more bloat needlessly. If you use 'struct bd_info' instead, it is enough to put a forward declaration as follows: struct bd_info; void foo(struct bd_info *bd); Right, typedef'ing bd_t is a mistake. I used coccinelle to generate this commit. The semantic patch that makes this change is as follows: @@ typedef bd_t; @@ -bd_t +struct bd_info Signed-off-by: Masahiro Yamada --- include/fsl_esdhc.h | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) (limited to 'include/fsl_esdhc.h') diff --git a/include/fsl_esdhc.h b/include/fsl_esdhc.h index e148eaa880..2615d1ad2f 100644 --- a/include/fsl_esdhc.h +++ b/include/fsl_esdhc.h @@ -204,16 +204,16 @@ struct fsl_esdhc_cfg { #endif #ifdef CONFIG_FSL_ESDHC -int fsl_esdhc_mmc_init(bd_t *bis); -int fsl_esdhc_initialize(bd_t *bis, struct fsl_esdhc_cfg *cfg); -void fdt_fixup_esdhc(void *blob, bd_t *bd); +int fsl_esdhc_mmc_init(struct bd_info *bis); +int fsl_esdhc_initialize(struct bd_info *bis, struct fsl_esdhc_cfg *cfg); +void fdt_fixup_esdhc(void *blob, struct bd_info *bd); #ifdef MMC_SUPPORTS_TUNING static inline int fsl_esdhc_execute_tuning(struct udevice *dev, uint32_t opcode) {return 0; } #endif #else -static inline int fsl_esdhc_mmc_init(bd_t *bis) { return -ENOSYS; } -static inline void fdt_fixup_esdhc(void *blob, bd_t *bd) {} +static inline int fsl_esdhc_mmc_init(struct bd_info *bis) { return -ENOSYS; } +static inline void fdt_fixup_esdhc(void *blob, struct bd_info *bd) {} #endif /* CONFIG_FSL_ESDHC */ void __noreturn mmc_boot(void); void mmc_spl_load_image(uint32_t offs, unsigned int size, void *vdst); -- cgit v1.2.3