From c3dc39a2f85b16bf590789f7e283cd72275cd168 Mon Sep 17 00:00:00 2001 From: Simon Glass Date: Sun, 10 May 2020 11:39:55 -0600 Subject: arm: Don't include common.h in header files It is bad practice to include common.h in other header files since it can bring in any number of superfluous definitions. It implies that some C files don't include it and thus may be missing CONFIG options that are set up by that file. The C files should include these themselves. Update some header files in arch/arm to drop this. Signed-off-by: Simon Glass --- include/net.h | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) (limited to 'include/net.h') diff --git a/include/net.h b/include/net.h index 82500eeb30..774ae2de63 100644 --- a/include/net.h +++ b/include/net.h @@ -15,9 +15,13 @@ #include #include /* for nton* / ntoh* stuff */ #include +#include +#include #include #include +struct cmd_tbl_s; + #define DEBUG_LL_STATE 0 /* Link local state machine changes */ #define DEBUG_DEV_PKT 0 /* Packets or info directed to the device */ #define DEBUG_NET_PKT 0 /* Packets on info on the network at large */ @@ -59,7 +63,7 @@ struct in_addr { * @argv: List of arguments * @return result (see enum command_ret_t) */ -int do_tftpb(cmd_tbl_t *cmdtp, int flag, int argc, char *const argv[]); +int do_tftpb(struct cmd_tbl_s *cmdtp, int flag, int argc, char *const argv[]); /** * An incoming packet handler. -- cgit v1.2.3