From b75d8dc5642b71eb029e7cd38031a32029e736cc Mon Sep 17 00:00:00 2001 From: Masahiro Yamada Date: Fri, 26 Jun 2020 15:13:33 +0900 Subject: treewide: convert bd_t to struct bd_info by coccinelle The Linux coding style guide (Documentation/process/coding-style.rst) clearly says: It's a **mistake** to use typedef for structures and pointers. Besides, using typedef for structures is annoying when you try to make headers self-contained. Let's say you have the following function declaration in a header: void foo(bd_t *bd); This is not self-contained since bd_t is not defined. To tell the compiler what 'bd_t' is, you need to include #include void foo(bd_t *bd); Then, the include direcective pulls in more bloat needlessly. If you use 'struct bd_info' instead, it is enough to put a forward declaration as follows: struct bd_info; void foo(struct bd_info *bd); Right, typedef'ing bd_t is a mistake. I used coccinelle to generate this commit. The semantic patch that makes this change is as follows: @@ typedef bd_t; @@ -bd_t +struct bd_info Signed-off-by: Masahiro Yamada --- lib/fdtdec.c | 3 ++- lib/lmb.c | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) (limited to 'lib') diff --git a/lib/fdtdec.c b/lib/fdtdec.c index 0dd7ff1ac3..934944d97f 100644 --- a/lib/fdtdec.c +++ b/lib/fdtdec.c @@ -1582,7 +1582,8 @@ int fdtdec_resetup(int *rescan) #ifdef CONFIG_NR_DRAM_BANKS int fdtdec_decode_ram_size(const void *blob, const char *area, int board_id, - phys_addr_t *basep, phys_size_t *sizep, bd_t *bd) + phys_addr_t *basep, phys_size_t *sizep, + struct bd_info *bd) { int addr_cells, size_cells; const u32 *cell, *end; diff --git a/lib/lmb.c b/lib/lmb.c index 008bcc7930..2d680d8d02 100644 --- a/lib/lmb.c +++ b/lib/lmb.c @@ -111,7 +111,7 @@ static void lmb_reserve_common(struct lmb *lmb, void *fdt_blob) } /* Initialize the struct, add memory and call arch/board reserve functions */ -void lmb_init_and_reserve(struct lmb *lmb, bd_t *bd, void *fdt_blob) +void lmb_init_and_reserve(struct lmb *lmb, struct bd_info *bd, void *fdt_blob) { #ifdef CONFIG_NR_DRAM_BANKS int i; -- cgit v1.2.3