summaryrefslogtreecommitdiff
path: root/config
diff options
context:
space:
mode:
authorNinad Palsule <ninadpalsule@us.ibm.com>2023-04-20 23:11:21 +0300
committerEd Tanous <edtanous@google.com>2023-05-31 23:27:53 +0300
commit5fd0aafb0f14fb3011970e8575647bb608688c7c (patch)
tree01694d4501e0bf3a734dea0e1c52ec8a7e7c819b /config
parent13451e3913c29bb380ef6778f11749d337ddd442 (diff)
downloadbmcweb-5fd0aafb0f14fb3011970e8575647bb608688c7c.tar.xz
Disabled processor and memory summary status
Redfish deprecated the Processor/Memory Summary Status (state, health, healthrollup) attributes. Please refer to redfish spec for more details: https://redfish.dmtf.org/schemas/v1/ComputerSystem.v1_20_0.json Initially I tried to fix the summary status issues, (https://gerrit.openbmc.org/c/openbmc/bmcweb/+/60663) But later it was decided that we should also remove these attributes from the bmcweb code. Here is a link to discussion on discord: https://discord.com/channels/775381525260664832/855566794994221117/1093939076710793296 This drop hides these attributes under defined BMCWEB_ENABLE_PROC_MEM_STATUS. This option is disabled by default. These attributes will be permanently removed from code in 1Q 2024 (in 8-9 months). Testing: - Redfish validator passed excepted couple of failures but those are failing without my changes too. - Make sure that summary status for memory and processor is not seen in the output. Without fix: ------------ ''' $ curl -s -k https://${bmc}/redfish/v1/Systems/system ..... "MemorySummary": { "Status": { "Health": "OK", "HealthRollup": "OK", "State": "Enabled" }, "TotalSystemMemoryGiB": 256 }, ..... "ProcessorSummary": { "CoreCount": 20, "Count": 4, "Status": { "Health": "OK", "HealthRollup": "OK", "State": "Enabled" } }, ..... '''' With fix: --------- ''' "MemorySummary": { "TotalSystemMemoryGiB": 256 }, ..... "ProcessorSummary": { "CoreCount": 20, "Count": 4 }, ..... '''' - Turned on BMCWEB_ALLOW_DEPRECATED_PROC_MEM_STATUS flag and made sure that properties are shown again. Change-Id: I1e0ee386bd4f365599afcf46e5d587285af635ad Signed-off-by: Ninad Palsule <ninadpalsule@us.ibm.com> Signed-off-by: Ed Tanous <edtanous@google.com>
Diffstat (limited to 'config')
-rw-r--r--config/bmcweb_config.h.in1
-rw-r--r--config/meson.build2
2 files changed, 3 insertions, 0 deletions
diff --git a/config/bmcweb_config.h.in b/config/bmcweb_config.h.in
index 1290bd652f..df16bc1a07 100644
--- a/config/bmcweb_config.h.in
+++ b/config/bmcweb_config.h.in
@@ -19,4 +19,5 @@ constexpr const char* bmcwebLoggingLevel = "@BMCWEB_LOGGING_LEVEL@";
constexpr const bool bmcwebEnableHealthPopulate = @BMCWEB_ENABLE_HEALTH_POPULATE@ == 1;
+constexpr const bool bmcwebEnableProcMemStatus = @BMCWEB_ENABLE_PROC_MEM_STATUS@ == 1;
// clang-format on
diff --git a/config/meson.build b/config/meson.build
index bd8aada7c1..6464024e05 100644
--- a/config/meson.build
+++ b/config/meson.build
@@ -15,6 +15,8 @@ conf_data.set('HTTPS_PORT', get_option('https_port'))
conf_data.set('HTTPS_PORT', get_option('https_port'))
enable_health_populate = get_option('health-populate')
conf_data.set10('BMCWEB_ENABLE_HEALTH_POPULATE', enable_health_populate.enabled())
+enable_proc_mem_status = get_option('redfish-enable-proccessor-memory-status')
+conf_data.set10('BMCWEB_ENABLE_PROC_MEM_STATUS', enable_proc_mem_status.enabled())
# Logging level
loglvlopt = get_option('bmcweb-logging')