diff options
| author | Ed Tanous <edtanous@google.com> | 2023-07-25 03:01:38 +0300 |
|---|---|---|
| committer | Ed Tanous <ed@tanous.net> | 2023-07-27 20:23:04 +0300 |
| commit | e7245fe847e7282522a7979f816fd76f925348d3 (patch) | |
| tree | 86a14497e2c6990e3609d6a4af9c12932f0d5b53 /config | |
| parent | 630adcdc7e705d020dd75de2bd335821863d20e9 (diff) | |
| download | bmcweb-e7245fe847e7282522a7979f816fd76f925348d3.tar.xz | |
Fix logging
The recent change to logging has caused a couple of bugs. First, when
building within yocto, the complete path is now returned on log
messages. This is wasteful of speed, and not super helpful to
developers to have a full path. Per the discussion on the original
patchset, drop this down to just the filename.
2, because of it's use as a pseudo log level, "enabled" is in the list
of strings. This causes an index mismatch, which causes logs to be
logged at the wrong level beyond debug. Move the entry to the end to
fix this.
Third, move the logging of level to upper case, to follow the old
convention.
Tested:
Enabled meson option for logging, observed logs like:
```
Jul 25 18:39:20 qemux86-64 bmcweb[209]: [DEBUG query.hpp:121] setup redfish route
Jul 25 18:39:20 qemux86-64 bmcweb[209]: [DEBUG http_response.hpp:248] 0x561bc11a7a40 releasing ce
Jul 25 18:39:20 qemux86-64 bmcweb[209]: [DEBUG http_response.hpp:238] 0x561bc11a7a40 setting comr
Jul 25 18:39:20 qemux86-64 bmcweb[209]: [DEBUG http_response.hpp:223] 0x561bc11a7a40 calling comr
Jul 25 18:39:20 qemux86-64 bmcweb[209]: [DEBUG http_response.hpp:226] 0x561bc11a7a40 completion d
Jul 25 18:39:20 qemux86-64 bmcweb[209]: [DEBUG query_param.hpp:1019] Processing query params
```
Change-Id: I4ac506c623a17f81ae83545e59291d2729dc82cb
Signed-off-by: Ed Tanous <edtanous@google.com>
Diffstat (limited to 'config')
| -rw-r--r-- | config/meson.build | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/config/meson.build b/config/meson.build index 8a72a63e37..7f2318f135 100644 --- a/config/meson.build +++ b/config/meson.build @@ -27,6 +27,7 @@ if get_option('buildtype').startswith('debug') and loglvlopt == 'disabled' # Override logging level as 'debug' if 'bmcweb-logging' is set as 'dsiabled' loglvlopt = 'debug' endif +loglvlopt = loglvlopt.to_upper() conf_data.set('BMCWEB_LOGGING_LEVEL', loglvlopt) conf_h_dep = declare_dependency( |