| Age | Commit message (Collapse) | Author | Files | Lines |
|---|
|
I have multiple email addresses in my Gerrit account but as
https://gerrit.openbmc.org/c/openbmc/bmcweb/+/69506 shows my Preferred
email has to match the OWNERS file, do that.
More discussion in Discord at
[1] https://discord.com/channels/775381525260664832/817151035197358081/1209585278025601094
Change-Id: I94ba5bd8d9c2a3c23314aae051b3a083562e43cb
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
|
phosphor-webui has been replaced by webui-vue. It has been proposed to
archive it, no point in referencing it or requiring knowledge of it to
be a maintainer.
Tested: None. Doc change only.
Change-Id: I3fab9eff7960174815cfc822abbb4e0d3f970a5c
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
|
Reason: I will be leaving OpenBmc project soon.
Change-Id: I726eaafe38a15636fd855b591bb73b5c62108a5a
Signed-off-by: Krzysztof Grobelny <krzysztof.grobelny@intel.com>
|
|
It's |log_services| not |log_service|.
Signed-off-by: Nan Zhou <nanzhoumails@gmail.com>
Change-Id: Ic504a3fcc5b69ce4a05de943ebf0d6c95fbdcda4
|
|
The existing config is missing owners in exact match. Also, onwers have
to be array of strings.
Reference:
[1] https://gerrit.googlesource.com/plugins/owners/+/refs/heads/master/config.md
Signed-off-by: Nan Zhou <nanzhoumails@gmail.com>
Change-Id: Ic9639f5e6c83d4dee947c3fddc48de43f0d6aa61
|
|
I developed a fair amount of the query parameter codes and had a fair
understanding of how it works, what the next steps are, how to review
related codes, how to test it. Thus, propose that I own these codes.
Signed-off-by: Nan Zhou <nanzhoumails@gmail.com>
Change-Id: I9c5a4ca5f7d569f3523afb3d97aa367f46314220
|
|
As bmcweb grows, it's important that we distribute the load amongst the
available community. This commit pivots slightly from our usual process
of giving full repo maintainership to a small list of one or two people,
and instead proposes passing out smaller pieces of maintainership. The
hope is that over time, these maintainers can grow into owning larger
portions of the stack.
In this way, we can increase our breadth of available maintainers for
the things that are straightforward, like adding new redfish schemas or
doing migrations, while still keeping a few core maintainers responsible
for the core.
I've reached out to both Krzysztof and Nan, and asked them which pieces
they feel that they're comfortable maintaining, and I've added all
components they listed to the OWNERS files. Each has a track record of
doing reviews in upstream, and given that Gunnar and myself will still
be present and active, this seems like a good thing for the project
overall.
The specific sections of maintainership for each person is laid out in
the OWNERS file, and we can modify over time as each person gets more
experience in reviewing and testing.
The expectations are that for the files explicitly listed, these new
maintainers will be able to handle all reviews that touch those sections
of functionality (including reviews not yet merged). Please continue to
communicate as you have previously.
To those being added, it is expected that if there are core issues
brought up in the modules that you maintain, you escalate them to the
entire group of maintainers, and remain active on our communication
channels. In the past, we've had significant issues where individual
modules tried to implement generalized solutions in a handler-specific
way, and while most of that has been cleaned up, it caused significant
thrash. Lets try to avoid that going forward.
I look forward to working with both of you more.
Change-Id: I7750a12703af68fc82f84a0e22496dabca582208
Signed-off-by: Ed Tanous <edtanous@google.com>
|
|
Signed-off-by: Nan Zhou <nanzhoumails@gmail.com>
Change-Id: I16ba4436099c959cff16e67a4e8f1b9bd2ed047e
|
|
In the past, a number of contributors have inquired about what bmcweb
maintainers do, and how they can become one. As bmcweb grows in
popularity and scope, it's important that we be able to spread out the
load amongst more maintainers, and make sure that we're including
community members, while still keeping the core principles that made
bmcweb attract so many users intact.
To that end, I've attempted to document, in the OWNERS file, the basic
responsibilities that are required to be a maintainer within bmcweb. I
very much expect that this list evolves over time, but this is expected
to be a starting point, and a place to point people that are interested
in becoming a maintainer of bmcweb.
As a pattern, I would like to see this kind of "how to be a maintainer
of this component" called out in more repositories, as I believe it
opens up the community to more people, common solutions, and better
results.
Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: Id156edd7e340df9432bf5a8a73e8a117b5d4099a
|
|
Krzysztof was added as a reviewer in the MAINTAINERS file but not OWNERS
file as part of 4576ec1.
Add Krzysztof as a reviewer in OWNERS.
One day this should mean Krzysztof is automatically added to bmcweb
reviews, after support for automatically adding Reviewers is added.
Copied syntax from other repos OWNERS. E.g.
https://github.com/openbmc/docs/blob/master/OWNERS#L39
Change-Id: I6b721fe5d6eb1c45a9476c2b89d25b6998f6bb1d
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
|
I have not been able to dedicate the amount of time to bmcweb
that I would like to as a maintainer, so I am removing myself.
Change-Id: Ie9fdf0b6cf5074d6454e88d61c2c24925f69202d
Signed-off-by: Jason M. Bills <jason.m.bills@linux.intel.com>
|
|
The OWNERS file allows gerrit to automatically CC the owners on a review
when it's pushed, removing the need to add maintainers manually.
This is somewhat an experiment. If it's successful, we should do this
on all OpenBMC subrepos, and is also in line with us deprecating all the
MAINTAINERS files.
Tested:
Gerrit only, can't test until it's on mainline.
Change-Id: I5d921e4b08f609784a522ecd2cd51b3e825e9d0f
Signed-off-by: Ed Tanous <edtanous@google.com>
|
