diff options
| author | Hans de Goede <hdegoede@redhat.com> | 2020-09-03 14:23:37 +0300 |
|---|---|---|
| committer | Hans de Goede <hdegoede@redhat.com> | 2020-09-06 16:53:37 +0300 |
| commit | f8bd54d2190469e2244ade66cc1551b2a8f4f138 (patch) | |
| tree | 9fa0e8d09c7aa99eab32cc02a37a363644c53a24 /drivers/gpu/drm/i915/intel_device_info.c | |
| parent | 9a6ae5b354ed09f61cfa3acbb19fecd64f46b097 (diff) | |
| download | linux-f8bd54d2190469e2244ade66cc1551b2a8f4f138.tar.xz | |
drm/i915: panel: Use atomic PWM API for devs with an external PWM controller
Now that the PWM drivers which we use have been converted to the atomic
PWM API, we can move the i915 panel code over to using the atomic PWM API.
The removes a long standing FIXME and this removes a flicker where
the backlight brightness would jump to 100% when i915 loads even if
using the fastset path.
Note that this commit also simplifies pwm_disable_backlight(), by dropping
the intel_panel_actually_set_backlight(..., 0) call. This call sets the
PWM to 0% duty-cycle. I believe that this call was only present as a
workaround for a bug in the pwm-crc.c driver where it failed to clear the
PWM_OUTPUT_ENABLE bit. This is fixed by an earlier patch in this series.
After the dropping of this workaround, the usleep call, which seems
unnecessary to begin with, has no useful effect anymore, so drop that too.
Acked-by: Jani Nikula <jani.nikula@intel.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20200903112337.4113-18-hdegoede@redhat.com
Diffstat (limited to 'drivers/gpu/drm/i915/intel_device_info.c')
0 files changed, 0 insertions, 0 deletions