diff options
author | Heiner Kallweit <hkallweit1@gmail.com> | 2021-11-24 10:16:25 +0300 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2021-12-01 11:04:52 +0300 |
commit | cc1645427a0f258467de1fa9ebfc293344c1a719 (patch) | |
tree | a829c95688b2e8fdb990442343ba3109c2b0a639 /drivers/net/ethernet/microchip/lan743x_ethtool.c | |
parent | 8165a96f6b7122f25bf809aecf06f17b0ec37b58 (diff) | |
download | linux-cc1645427a0f258467de1fa9ebfc293344c1a719.tar.xz |
lan743x: fix deadlock in lan743x_phy_link_status_change()
[ Upstream commit ddb826c2c92d461f290a7bab89e7c28696191875 ]
Usage of phy_ethtool_get_link_ksettings() in the link status change
handler isn't needed, and in combination with the referenced change
it results in a deadlock. Simply remove the call and replace it with
direct access to phydev->speed. The duplex argument of
lan743x_phy_update_flowcontrol() isn't used and can be removed.
Fixes: c10a485c3de5 ("phy: phy_ethtool_ksettings_get: Lock the phy for consistency")
Reported-by: Alessandro B Maurici <abmaurici@gmail.com>
Tested-by: Alessandro B Maurici <abmaurici@gmail.com>
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Link: https://lore.kernel.org/r/40e27f76-0ba3-dcef-ee32-a78b9df38b0f@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'drivers/net/ethernet/microchip/lan743x_ethtool.c')
0 files changed, 0 insertions, 0 deletions