summaryrefslogtreecommitdiff
path: root/drivers/usb/serial/f81232.c
diff options
context:
space:
mode:
authorJohan Hovold <jhovold@gmail.com>2013-12-29 22:22:57 +0400
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2014-01-04 00:31:47 +0400
commit49fabf29869c9c21f4d7243fa5b2b9ebc3890a85 (patch)
tree11d703da51b85b11dba4778b75449340a344b3b4 /drivers/usb/serial/f81232.c
parent10c642d0772ac1391ae4f9fdeb13217ab019117a (diff)
downloadlinux-49fabf29869c9c21f4d7243fa5b2b9ebc3890a85.tar.xz
USB: f81232: remove bogus call to wake up MSR queue
Remove bogus call to wake up delta_msr_wait from process_read_urb where the MSR status is never updated (only the LSR bits are masked out). Comment that the wake-up call should made in f81232_update_line_status when the MSR status changes. Note that this driver is still mostly stubbed out. Signed-off-by: Johan Hovold <jhovold@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/usb/serial/f81232.c')
-rw-r--r--drivers/usb/serial/f81232.c8
1 files changed, 7 insertions, 1 deletions
diff --git a/drivers/usb/serial/f81232.c b/drivers/usb/serial/f81232.c
index aeb2edca1ce6..42c55601b4c9 100644
--- a/drivers/usb/serial/f81232.c
+++ b/drivers/usb/serial/f81232.c
@@ -55,6 +55,13 @@ static void f81232_update_line_status(struct usb_serial_port *port,
unsigned char *data,
unsigned int actual_length)
{
+ /*
+ * FIXME: Call
+ *
+ * wake_up_interruptible(&port->port.delta_msr_wait);
+ *
+ * on MSR changes.
+ */
}
static void f81232_read_int_callback(struct urb *urb)
@@ -110,7 +117,6 @@ static void f81232_process_read_urb(struct urb *urb)
line_status = priv->line_status;
priv->line_status &= ~UART_STATE_TRANSIENT_MASK;
spin_unlock_irqrestore(&priv->lock, flags);
- wake_up_interruptible(&port->port.delta_msr_wait);
if (!urb->actual_length)
return;