diff options
author | Paolo Abeni <pabeni@redhat.com> | 2018-07-30 15:30:42 +0300 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2018-07-30 19:31:13 +0300 |
commit | 802bfb19152c0fb4137c6ba72bcf042ee023e743 (patch) | |
tree | 0330695824cf2ca9a5f5d270e4a161f7df857abf /net/sched/act_mirred.c | |
parent | c87fffc57adf7b772b3778a9521c3f2ff744ae82 (diff) | |
download | linux-802bfb19152c0fb4137c6ba72bcf042ee023e743.tar.xz |
net/sched: user-space can't set unknown tcfa_action values
Currently, when initializing an action, the user-space can specify
and use arbitrary values for the tcfa_action field. If the value
is unknown by the kernel, is implicitly threaded as TC_ACT_UNSPEC.
This change explicitly checks for unknown values at action creation
time, and explicitly convert them to TC_ACT_UNSPEC. No functional
changes are introduced, but this will allow introducing tcfa_action
values not exposed to user-space in a later patch.
Note: we can't use the above to hide TC_ACT_REDIRECT from user-space,
as the latter is already part of uAPI.
v3 -> v4:
- use an helper to check for action validity (JiriP)
- emit an extack for invalid actions (JiriP)
v4 -> v5:
- keep messages on a single line, drop net_warn (Marcelo)
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Acked-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/sched/act_mirred.c')
0 files changed, 0 insertions, 0 deletions