diff options
| author | Andrew Geissler <geissonator@yahoo.com> | 2020-06-01 23:39:17 +0300 |
|---|---|---|
| committer | Andrew Geissler <geissonator@yahoo.com> | 2020-06-08 22:24:52 +0300 |
| commit | ad6fc595134e4b104f5b25c4de66a5b68482f162 (patch) | |
| tree | 7fbef249bf50deea73bc4761bd508d27b3de4459 /meta-openpower/recipes-phosphor/fsi | |
| parent | ee8013c3c60f889dde7a35686962b0b90cf14df8 (diff) | |
| download | openbmc-ad6fc595134e4b104f5b25c4de66a5b68482f162.tar.xz | |
fsi-scan: make systemd wants relationship
systemd recommends a wants vs. requires relationship so this is a small
step in that direction for OpenBMC.
This also alleviates a common pain point in bringup where FSI is not
working properly or a FSI device is not present in the system. With a
requires relationship, the chassis poweron target fails. What a user
really wants is for the power on to still succeed.
Other firmware, which requires FSI, will detect issues during the host
boot and take proper actions.
Tested:
Injected fail into fsi-scan service and verified with this change that
chassis power on still succeeded.
(From meta-openpower rev: 58b758a36c28544ee31b75a1aa7dddd5d0fe355c)
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: I6615f81778430dd5d855149b97cba70fbba5f993
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Diffstat (limited to 'meta-openpower/recipes-phosphor/fsi')
| -rw-r--r-- | meta-openpower/recipes-phosphor/fsi/op-fsi.bb | 2 | ||||
| -rw-r--r-- | meta-openpower/recipes-phosphor/fsi/op-fsi/fsi-scan@.service | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/meta-openpower/recipes-phosphor/fsi/op-fsi.bb b/meta-openpower/recipes-phosphor/fsi/op-fsi.bb index e056d6d28..86cf5c1dc 100644 --- a/meta-openpower/recipes-phosphor/fsi/op-fsi.bb +++ b/meta-openpower/recipes-phosphor/fsi/op-fsi.bb @@ -12,7 +12,7 @@ TGTFMT = "obmc-chassis-poweron@{0}.target" TMPL_SCAN = "fsi-scan@.service" INSTFMT_SCAN = "fsi-scan@{0}.service" -FMT_SCAN = "../${TMPL_SCAN}:${TGTFMT}.requires/${INSTFMT_SCAN}" +FMT_SCAN = "../${TMPL_SCAN}:${TGTFMT}.wants/${INSTFMT_SCAN}" SYSTEMD_SERVICE_${PN} += "${TMPL_SCAN} fsi-enable.service fsi-disable.service" diff --git a/meta-openpower/recipes-phosphor/fsi/op-fsi/fsi-scan@.service b/meta-openpower/recipes-phosphor/fsi/op-fsi/fsi-scan@.service index d8f28882a..dd837efe7 100644 --- a/meta-openpower/recipes-phosphor/fsi/op-fsi/fsi-scan@.service +++ b/meta-openpower/recipes-phosphor/fsi/op-fsi/fsi-scan@.service @@ -14,4 +14,4 @@ Type=oneshot RemainAfterExit=yes [Install] -RequiredBy=obmc-chassis-poweron@%i.target +WantedBy=obmc-chassis-poweron@%i.target |