summaryrefslogtreecommitdiff
path: root/meta-openbmc-mods/meta-ast2500/recipes-bsp/u-boot/files/0034-Disable-uart-debug-interface.patch
blob: 941dc7d0d05021e058021ec5d0cd2b56011a2f28 (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
From 961561c437c8a3f3de1753c502a20c334966354e Mon Sep 17 00:00:00 2001
From: Yong Li <yong.b.li@linux.intel.com>
Date: Tue, 20 Aug 2019 16:10:03 +0800
Subject: [PATCH 1/2] Disable uart debug interface

AST2500 SOC integrates a UART debug interface which can
input commands to AST2500 by using simple terminal
program without the assistance of CPU.

For security requirements, we need to disable this feature,
set SCU2C[]10 = 1 to disable it.

Tested:
Flash the u-boot.bin and dump SCU2C as below:
md 0x1e6e202c
1e6e202c: 00200400

Signed-off-by: Yong Li <yong.b.li@linux.intel.com>
Signed-off-by: Vikram Bodireddy <vikram.bodireddy@intel.com>
---
 arch/arm/include/asm/arch-aspeed/regs-scu.h | 1 +
 board/aspeed/ast-g5/ast-g5-intel.c          | 4 ++++
 2 files changed, 5 insertions(+)

diff --git a/arch/arm/include/asm/arch-aspeed/regs-scu.h b/arch/arm/include/asm/arch-aspeed/regs-scu.h
index 8a596ceafc..8333ba1c59 100644
--- a/arch/arm/include/asm/arch-aspeed/regs-scu.h
+++ b/arch/arm/include/asm/arch-aspeed/regs-scu.h
@@ -467,6 +467,7 @@
 #define SCU_MISC_VUART_TO_CTRL		(0x1 << 13)
 #define SCU_MISC_DIV13_EN		(0x1 << 12)
 #define SCU_MISC_Y_CLK_INVERT		(0x1 << 11)
+#define SCU_MISC_UART_DEBUG_DIS		(0x1 << 10)
 #define SCU_MISC_OUT_DELAY		(0x1 << 9)
 #define SCU_MISC_PCI_TO_AHB_DIS		(0x1 << 8)
 #define SCU_MISC_2D_CRT_EN		(0x1 << 7)
diff --git a/board/aspeed/ast-g5/ast-g5-intel.c b/board/aspeed/ast-g5/ast-g5-intel.c
index 324387a4bc..c58fd3591b 100644
--- a/board/aspeed/ast-g5/ast-g5-intel.c
+++ b/board/aspeed/ast-g5/ast-g5-intel.c
@@ -578,6 +578,10 @@ extern void espi_init(void);
 extern void kcs_init(void);
 void ast_g5_intel(void)
 {
+	/* Disable uart port debug function */
+	ast_scu_write(ast_scu_read(AST_SCU_MISC1_CTRL) |
+		      SCU_MISC_UART_DEBUG_DIS, AST_SCU_MISC1_CTRL);
+
 	uart_init();
 	pwm_init();
 	gpio_init(gpio_table, ARRAY_SIZE(gpio_table));
-- 
2.17.1