1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
|
From a76314cd29f5cbcf19142b7120c5bf83358910fd Mon Sep 17 00:00:00 2001
From: Jayaprakash Mutyala <mutyalax.jayaprakash@intel.com>
Date: Mon, 28 Dec 2020 18:55:57 +0000
Subject: [PATCH] managers: add attributes for Manager.CommandShell
Issue: ConnectTypesSupported, ServiceEnabled and
MaxConcurrentSessions Attributes are missing for
Manager.CommandShell, though Requirement mandates it.
Fix: Added missing attributes to Manager.CommandShell
Tested:
1. Verified redfish validator passed
2. Get bmc details from Redfish
Redfish URI: https://<BMC IP>/redfish/v1/Managers/bmc
Response:
{
"@odata.id": "/redfish/v1/Managers/bmc",
"@odata.type": "#Manager.v1_9_0.Manager",
....
....
"CommandShell": {
"ConnectTypesSupported": [
"SSH",
"IPMI"
],
"MaxConcurrentSessions": 4,
"ServiceEnabled": true
},
....
....
Signed-off-by: Jayaprakash Mutyala <mutyalax.jayaprakash@intel.com>
---
redfish-core/lib/managers.hpp | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/redfish-core/lib/managers.hpp b/redfish-core/lib/managers.hpp
index 6347caf..c401ca9 100644
--- a/redfish-core/lib/managers.hpp
+++ b/redfish-core/lib/managers.hpp
@@ -1767,6 +1767,12 @@ class Manager : public Node
res.jsonValue["SerialConsole"]["MaxConcurrentSessions"] = 15;
res.jsonValue["SerialConsole"]["ConnectTypesSupported"] = {"IPMI",
"SSH"};
+ // Fill in CommandShell info
+ res.jsonValue["CommandShell"]["ServiceEnabled"] = true;
+ res.jsonValue["CommandShell"]["MaxConcurrentSessions"] = 4;
+ res.jsonValue["CommandShell"]["ConnectTypesSupported"] = {"SSH",
+ "IPMI"};
+
#ifdef BMCWEB_ENABLE_KVM
// Fill in GraphicalConsole info
res.jsonValue["GraphicalConsole"]["ServiceEnabled"] = true;
--
2.17.1
|
