1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
|
From 5cea18ba476c0cb6ea622be50a09ead00cd47b14 Mon Sep 17 00:00:00 2001
From: Ivan Li <rli11@lenovo.com>
Date: Wed, 25 Dec 2019 17:05:00 +0800
Subject: [PATCH] Add power on monitor mechanism
Summary:
1. Add "PWRONMON" attribute in sensor configuration file to determine whether it's power-on monitor sensor or not. (i.e. PWRONMON_temp1 = "ON")
2. Watching "CurrentHostState" property and then use it to turn on/off threshold alert for power-on monitor sensors.
Test Plan:
Check if there is any abnormal threshold events occurred in power off state or during power transition
Signed-off-by: Ivan Li <rli11@lenovo.com>
Change-Id: I76d3a664153141d94636e0011f3a48e4f6dee922
---
mainloop.cpp | 102 +++++++++++++++++++++++++++++++++++++++++++++++++
sensor.cpp | 11 +++++-
sensor.hpp | 13 +++++++
thresholds.hpp | 24 ------------
4 files changed, 125 insertions(+), 25 deletions(-)
diff --git a/mainloop.cpp b/mainloop.cpp
index 29dc26a..5e27a30 100644
--- a/mainloop.cpp
+++ b/mainloop.cpp
@@ -42,6 +42,13 @@
#include <string>
#include <unordered_set>
#include <xyz/openbmc_project/Sensor/Device/error.hpp>
+#include <boost/asio/io_service.hpp>
+#include <boost/container/flat_map.hpp>
+#include <boost/algorithm/string/predicate.hpp>
+#include <sdbusplus/asio/connection.hpp>
+#include <sdbusplus/asio/object_server.hpp>
+#include <sdbusplus/message/types.hpp>
+#include <sdbusplus/timer.hpp>
using namespace phosphor::logging;
@@ -110,6 +117,12 @@ decltype(Thresholds<CriticalObject>::deassertHighSignal)
Thresholds<CriticalObject>::deassertHighSignal =
&CriticalObject::criticalHighAlarmDeasserted;
+static std::unique_ptr<phosphor::Timer> cacheTimer = nullptr;
+static std::unique_ptr<sdbusplus::bus::match::match> powerMatch = nullptr;
+static bool powerStatusOn = false;
+static boost::asio::io_service io;
+static auto conn = std::make_shared<sdbusplus::asio::connection>(io);
+
void updateSensorInterfaces(InterfaceMap& ifaces, SensorValueType value)
{
for (auto& iface : ifaces)
@@ -137,6 +150,83 @@ void updateSensorInterfaces(InterfaceMap& ifaces, SensorValueType value)
}
}
+void powerStatusSet()
+{
+ powerStatusOn = true;
+ return;
+}
+
+void createTimer()
+{
+ if (cacheTimer == nullptr)
+ {
+ cacheTimer = std::make_unique<phosphor::Timer>(powerStatusSet);
+ }
+}
+
+bool isPowerOn(void)
+{
+ if (!powerMatch)
+ {
+ throw std::runtime_error("Power Match Not Created");
+ }
+ return powerStatusOn;
+}
+
+void setupPowerMatch(sdbusplus::bus::bus& bus)
+{
+ if (powerMatch)
+ {
+ return;
+ }
+
+ powerMatch = std::make_unique<sdbusplus::bus::match::match>(
+ bus,
+ "type='signal',interface='org.freedesktop.DBus.Properties',path='/xyz/"
+ "openbmc_project/state/"
+ "host0',arg0='xyz.openbmc_project.State.Host'",
+ [](sdbusplus::message::message& message) {
+ std::string objectName;
+ boost::container::flat_map<std::string, std::variant<std::string>>
+ values;
+ message.read(objectName, values);
+ auto findState = values.find("CurrentHostState");
+ if (findState != values.end())
+ {
+ bool on = boost::ends_with(
+ std::get<std::string>(findState->second), "Running");
+ if (!on)
+ {
+ cacheTimer->stop();
+ powerStatusOn = false;
+ return;
+ }
+ cacheTimer->start(std::chrono::duration_cast<std::chrono::microseconds>(
+ std::chrono::seconds(10)));
+ }
+ else {
+ powerStatusOn = false;
+ }
+ });
+
+ conn->async_method_call(
+ [](boost::system::error_code ec,
+ const std::variant<std::string>& state) {
+ if (ec)
+ {
+ return;
+ }
+ powerStatusOn =
+ boost::ends_with(std::get<std::string>(state), "Running");
+ },
+ "xyz.openbmc_project.State.Host",
+ "/xyz/openbmc_project/state/host0",
+ "org.freedesktop.DBus.Properties", "Get",
+ "xyz.openbmc_project.State.Host", "CurrentHostState");
+
+ createTimer();
+}
+
std::string MainLoop::getID(SensorSet::container_t::const_reference sensor)
{
std::string id;
@@ -418,6 +508,7 @@ void MainLoop::init()
_interval = std::strtoull(interval.c_str(), NULL, 10);
}
}
+ setupPowerMatch(_bus);
}
void MainLoop::read()
@@ -462,6 +553,12 @@ void MainLoop::read()
try
{
+ if(sensor->pwrOnMonitor() && !isPowerOn())
+ {
+ statusIface->functional(false);
+ continue;
+ }
+
if (sensor->hasFaultFile())
{
auto fault = _ioAccess->read(sensorSysfsType, sensorSysfsNum,
@@ -588,6 +685,11 @@ void MainLoop::read()
}
}
+ if(sensor->pwrOnMonitor() && !isPowerOn())
+ {
+ statusIface->functional(false);
+ continue;
+ }
updateSensorInterfaces(obj, value);
}
catch (const std::system_error& e)
diff --git a/sensor.cpp b/sensor.cpp
index ac2f896..72b45f8 100644
--- a/sensor.cpp
+++ b/sensor.cpp
@@ -32,7 +32,7 @@ Sensor::Sensor(const SensorSet::key_type& sensor,
const hwmonio::HwmonIOInterface* ioAccess,
const std::string& devPath) :
_sensor(sensor),
- _ioAccess(ioAccess), _devPath(devPath), _scale(0), _hasFaultFile(false)
+ _ioAccess(ioAccess), _devPath(devPath), _scale(0), _hasFaultFile(false), _pwrOnMonitor(false)
{
auto chip = env::getEnv("GPIOCHIP", sensor);
auto access = env::getEnv("GPIO", sensor);
@@ -61,6 +61,15 @@ Sensor::Sensor(const SensorSet::key_type& sensor,
auto senRmRCs = env::getEnv("REMOVERCS", sensor);
// Add sensor removal return codes defined per sensor
addRemoveRCs(senRmRCs);
+
+ auto pwrOnMon = env::getEnv("PWRONMON", sensor);
+ if (!pwrOnMon.empty())
+ {
+ if (pwrOnMon == "ON")
+ {
+ _pwrOnMonitor = true;
+ }
+ }
}
void Sensor::addRemoveRCs(const std::string& rcList)
diff --git a/sensor.hpp b/sensor.hpp
index 64d6e48..41c0fe7 100644
--- a/sensor.hpp
+++ b/sensor.hpp
@@ -151,6 +151,16 @@ class Sensor
return _hasFaultFile;
}
+ /**
+ * @brief Get whether the sensor only need to be monitored in power on state or not.
+ *
+ * @return - Boolean on whether the sensor only need to be monitored in power on state
+ */
+ inline bool pwrOnMonitor(void) const
+ {
+ return _pwrOnMonitor;
+ }
+
private:
/** @brief Sensor object's identifiers */
SensorSet::key_type _sensor;
@@ -172,6 +182,9 @@ class Sensor
/** @brief Tracks whether the sensor has a fault file or not. */
bool _hasFaultFile;
+
+ /** @brief Whether the sensor only need to be monitored in power on state or not. */
+ bool _pwrOnMonitor;
};
/**
diff --git a/thresholds.hpp b/thresholds.hpp
index 8d557fc..0ffe0ce 100644
--- a/thresholds.hpp
+++ b/thresholds.hpp
@@ -137,32 +137,8 @@ auto addThreshold(const std::string& sensorType, const std::string& sensorID,
auto hi = stod(tHi) * std::pow(10, scale);
(*iface.*Thresholds<T>::setLo)(lo);
(*iface.*Thresholds<T>::setHi)(hi);
- auto alarmLowState = (*iface.*Thresholds<T>::getAlarmLow)();
- auto alarmHighState = (*iface.*Thresholds<T>::getAlarmHigh)();
(*iface.*Thresholds<T>::alarmLo)(value <= lo);
(*iface.*Thresholds<T>::alarmHi)(value >= hi);
- if (alarmLowState != (value <= lo))
- {
- if (value <= lo)
- {
- (*iface.*Thresholds<T>::assertLowSignal)(value);
- }
- else
- {
- (*iface.*Thresholds<T>::deassertLowSignal)(value);
- }
- }
- if (alarmHighState != (value >= hi))
- {
- if (value >= hi)
- {
- (*iface.*Thresholds<T>::assertHighSignal)(value);
- }
- else
- {
- (*iface.*Thresholds<T>::deassertHighSignal)(value);
- }
- }
auto type = Thresholds<T>::type;
obj[type] = iface;
}
--
2.21.0
|
