diff options
| author | Patrick Williams <patrick@stwcx.xyz> | 2022-09-09 01:35:35 +0300 |
|---|---|---|
| committer | Ed Tanous <ed@tanous.net> | 2022-09-09 17:33:09 +0300 |
| commit | 62bafc01bf4f4e2017d4a9e8d6d053f24ca30563 (patch) | |
| tree | 4f9760fba8d6978f35fd844fb4654f8d906733b0 | |
| parent | 2e30bc2dfc54ea81f4b5e537b233f8ab50967109 (diff) | |
| download | bmcweb-62bafc01bf4f4e2017d4a9e8d6d053f24ca30563.tar.xz | |
clang-tidy: fix misc warnings
The following error reports have started to be reported by clang-tidy:
* readability-qualified-auto - add 'const' to `auto&` iterators
* bugprone-use-after-move - add break in loop after element is found
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I5314559f62f58aa032d4c74946b8e3e4ce6be808
| -rw-r--r-- | include/dbus_monitor.hpp | 2 | ||||
| -rw-r--r-- | include/openbmc_dbus_rest.hpp | 2 | ||||
| -rw-r--r-- | redfish-core/include/utils/json_utils.hpp | 2 | ||||
| -rw-r--r-- | redfish-core/lib/event_service.hpp | 2 | ||||
| -rw-r--r-- | redfish-core/lib/update_service.hpp | 2 |
5 files changed, 6 insertions, 4 deletions
diff --git a/include/dbus_monitor.hpp b/include/dbus_monitor.hpp index 129422e4ae..5f409d7d70 100644 --- a/include/dbus_monitor.hpp +++ b/include/dbus_monitor.hpp @@ -84,7 +84,7 @@ inline int onPropertyUpdate(sd_bus_message* m, void* userdata, } // data is type oa{sa{sv}} which is an array[2] of string, object - for (auto& entry : data[1].items()) + for (const auto& entry : data[1].items()) { auto it = thisSession->second.interfaces.find(entry.key()); if (it != thisSession->second.interfaces.end()) diff --git a/include/openbmc_dbus_rest.hpp b/include/openbmc_dbus_rest.hpp index d8a4e66d6f..95503d706e 100644 --- a/include/openbmc_dbus_rest.hpp +++ b/include/openbmc_dbus_rest.hpp @@ -1768,7 +1768,7 @@ inline void handleGet(const std::shared_ptr<bmcweb::AsyncResp>& asyncResp, } else { - for (auto& prop : properties.items()) + for (const auto& prop : properties.items()) { // if property name is empty, or // matches our search query, add it diff --git a/redfish-core/include/utils/json_utils.hpp b/redfish-core/include/utils/json_utils.hpp index 0d4bee2807..a7a27ffb2a 100644 --- a/redfish-core/include/utils/json_utils.hpp +++ b/redfish-core/include/utils/json_utils.hpp @@ -410,7 +410,7 @@ inline bool readJsonHelper(nlohmann::json& jsonRequest, crow::Response& res, messages::unrecognizedRequestBody(res); return false; } - for (auto& item : jsonRequest.items()) + for (const auto& item : jsonRequest.items()) { size_t unpackIndex = 0; for (; unpackIndex < toUnpack.size(); unpackIndex++) diff --git a/redfish-core/lib/event_service.hpp b/redfish-core/lib/event_service.hpp index 29175abe58..9c5b378dd9 100644 --- a/redfish-core/lib/event_service.hpp +++ b/redfish-core/lib/event_service.hpp @@ -573,7 +573,7 @@ inline void requestRoutesEventDestination(App& app) boost::beast::http::fields fields; for (const nlohmann::json& headerChunk : *headers) { - for (auto& it : headerChunk.items()) + for (const auto& it : headerChunk.items()) { const std::string* value = it.value().get_ptr<const std::string*>(); diff --git a/redfish-core/lib/update_service.hpp b/redfish-core/lib/update_service.hpp index 9acf5689c6..ab99dc306a 100644 --- a/redfish-core/lib/update_service.hpp +++ b/redfish-core/lib/update_service.hpp @@ -249,6 +249,8 @@ static void "xyz.openbmc_project.ObjectMapper", "GetObject", objPath.str, std::array<const char*, 1>{ "xyz.openbmc_project.Software.Activation"}); + + break; } } } |