diff options
| author | Ed Tanous <edtanous@google.com> | 2023-02-16 21:28:44 +0300 |
|---|---|---|
| committer | Ed Tanous <ed@tanous.net> | 2023-02-24 20:21:14 +0300 |
| commit | 26ccae32112679c4653c1e3f8a1203c828bea05c (patch) | |
| tree | a87d5056294e163b9ddeed9e867bcfb0750a8bb5 /COMMON_ERRORS.md | |
| parent | 7da1c58890e82194ff83ca6c8d55b5c327f2444a (diff) | |
| download | bmcweb-26ccae32112679c4653c1e3f8a1203c828bea05c.tar.xz | |
Pass string views by value
string_view should always be passed by value; This commit is a sed
replace of the code to make all string_views pass by value, per general
coding guidelines[1].
[1] https://quuxplusone.github.io/blog/2021/11/09/pass-string-view-by-value/
Tested: Code compiles.
Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: I55b342a29a0fbfce0a4ed9ea63db6014d03b134c
Diffstat (limited to 'COMMON_ERRORS.md')
| -rw-r--r-- | COMMON_ERRORS.md | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/COMMON_ERRORS.md b/COMMON_ERRORS.md index 6cb7340bfd..aa4b042654 100644 --- a/COMMON_ERRORS.md +++ b/COMMON_ERRORS.md @@ -23,7 +23,7 @@ This pointer is not guaranteed to be filled, and could be a null dereference. ## 2. String views aren't null terminated ```cpp -int getIntFromString(const std::string_view s){ +int getIntFromString(std::string_view s){ return std::atoi(s.data()); } ``` |