summaryrefslogtreecommitdiff
path: root/http
diff options
context:
space:
mode:
authorGunnar Mills <gmills@us.ibm.com>2023-10-25 17:14:07 +0300
committerGunnar Mills <gunnar@gmills.xyz>2024-04-01 20:35:58 +0300
commit4f63be0cda9f0bf0f41ded6077070ca4b5e7840d (patch)
tree323b4f54c2401ab2712989e61ce021de3610379b /http
parentf6b5541b8b40e0867085c25a1e818297b0a5a447 (diff)
downloadbmcweb-4f63be0cda9f0bf0f41ded6077070ca4b5e7840d.tar.xz
Up the max connectionCount to 200
Have seen defects where hitting the max connection limit with multiple server managers attached. Although not common to exceed 100, can hit this when using 2 or 3 webui-vue GUIs and a server manager attached. webui-vue can use ~30 of these on its own; this isn't that hard to hit. Nginx by default sets 512 connections[1] , so 200 for an embedded target doesn't seem that unreasonable: Apache sets 256 by default [2] lighttpd sets 1024 [3] We're in line for the defaults for other webservers. Tested: Sent 180 basic auth requests seen bmcweb memory at 2189 2178 root R 29080 4% 49% ./bmcweb This was on a AST2600 (p10bmc) The connections open got to: [DEBUG "http_connection.hpp":79] 0x19bb5c8 Connection open, total 161 Came back down as expected: [DEBUG "http_connection.hpp":89] 0x1a41440 Connection closed, total 1 Didn't see this with multiple webui-vues / server managers. [1] https://nginx.org/en/docs/ngx_core_module.html#worker_connections [2] https://httpd.apache.org/docs/2.4/mod/mpm_common.html#maxrequestworkers [3] https://redmine.lighttpd.net/projects/1/wiki/Server_max-connectionsDetails Change-Id: I807302e32e61e31212850a480d721d89d484593f Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
Diffstat (limited to 'http')
-rw-r--r--http/http_connection.hpp2
1 files changed, 1 insertions, 1 deletions
diff --git a/http/http_connection.hpp b/http/http_connection.hpp
index d60e74b9a5..83645eeeb7 100644
--- a/http/http_connection.hpp
+++ b/http/http_connection.hpp
@@ -158,7 +158,7 @@ class Connection :
void start()
{
- if (connectionCount >= 100)
+ if (connectionCount >= 200)
{
BMCWEB_LOG_CRITICAL("{}Max connection count exceeded.",
logPtr(this));