diff options
| author | Ed Tanous <ed@tanous.net> | 2021-02-20 22:04:01 +0300 |
|---|---|---|
| committer | Ed Tanous <ed@tanous.net> | 2021-03-11 18:04:55 +0300 |
| commit | efb8062c306474942bc94f15d748b2eb0b58fbb6 (patch) | |
| tree | 19ed0b593882dea01708a2e4407061aab3697bd5 /meson_options.txt | |
| parent | 788ca5071ae33d9db9952ae17ce563e18c2550e9 (diff) | |
| download | bmcweb-efb8062c306474942bc94f15d748b2eb0b58fbb6.tar.xz | |
Disable nbd proxy from the build
The inline comment mostly describes this patchset. As far as OpenBMC is
concerned, no platforms or distros implement a backend for this code,
therefore this is dead "unused" code. Clearly the authors intended to
use it, but haven't been able to upstream anything.
For the moment, this patchset makes the nbd proxy option unenablable.
This will have no impact to any OpenBMC platforms, as there are no
implementations of this API in OpenBMC itself, only in downstream forks.
It's not clear what the intentions are with this code, so hopefully this
disabling and comment encourages those that care about it to interact
and add some details around how this was designed, and the plans to
upstream it into OpenBMC. If not, presumably the code can be deleted
without any harm.
For timelines, this was checked in Jul 12, 2019, so we're now 20 months
past its initial entry. This seems like enough time for the dust to
have settled on getting the appropriate things upstreamed.
Signed-off-by: Ed Tanous <ed@tanous.net>
Change-Id: I217493b97d62282b8781608805bcfe319e6f7d85
Diffstat (limited to 'meson_options.txt')
| -rw-r--r-- | meson_options.txt | 9 |
1 files changed, 8 insertions, 1 deletions
diff --git a/meson_options.txt b/meson_options.txt index 1298b968cd..5e5f7b503d 100644 --- a/meson_options.txt +++ b/meson_options.txt @@ -3,7 +3,14 @@ option('yocto-deps', type: 'feature', value: 'disabled', description : 'Use YOCT option('kvm', type : 'feature',value : 'enabled', description : 'Enable the KVM host video WebSocket. Path is \'/kvm/0\'. Video is from the BMC\'s \'/dev/video\' device.') option ('tests', type : 'feature', value : 'enabled', description : 'Enable Unit tests for bmcweb') option('vm-websocket', type : 'feature', value : 'enabled', description : '''Enable the Virtual Media WebSocket. Path is \'/vm/0/0\'to open the websocket. See https://github.com/openbmc/jsnbd/blob/master/README.''') -option('vm-nbdproxy', type: 'feature', value : 'disabled', description : 'Enable the Virtual Media WebSocket.') + +# if you use this option and are seeing this comment, please comment here: +# https://github.com/openbmc/bmcweb/issues/188 and put forward your intentions +# for this code. At this point, no daemon has been upstreamed that implements +# this interface, so for the moment this appears to be dead code; In leiu of +# removing it, it has been disabled to try to give those that use it the +# opportunity to upstream their backend implementation +#option('vm-nbdproxy', type: 'feature', value : 'disabled', description : 'Enable the Virtual Media WebSocket.') option('rest', type : 'feature', value : 'enabled', description : '''Enable Phosphor REST (D-Bus) APIs. Paths directly map Phosphor D-Bus object paths, for example, \'/xyz/openbmc_project/logging/entry/enumerate\'. See https://github.com/openbmc/docs/blob/master/rest-api.md.''') option('redfish', type : 'feature',value : 'enabled', description: 'Enable Redfish APIs. Paths are under \'/redfish/v1/\'. See https://github.com/openbmc/bmcweb/blob/master/DEVELOPING.md#redfish.') option('host-serial-socket', type : 'feature', value : 'enabled', description : 'Enable host serial console WebSocket. Path is \'/console0\'. See https://github.com/openbmc/docs/blob/master/console.md.') |