diff options
author | Ed Tanous <edtanous@google.com> | 2022-02-15 07:42:02 +0300 |
---|---|---|
committer | Ed Tanous <edtanous@google.com> | 2022-03-09 20:21:15 +0300 |
commit | 56d2396d090ee873d58c58737382758d2afea8b9 (patch) | |
tree | e6aa06c41dcd7495380c54c88840b5b37d71da26 /redfish-core/include | |
parent | 5f2b84ee090bb9d361de9c294aa85cecf3962c11 (diff) | |
download | bmcweb-56d2396d090ee873d58c58737382758d2afea8b9.tar.xz |
Enable 3 member function checks
The only changes were to make some functions static, which is
essentially no-op.
Changes were done by the robot.
Tested: Unit tests pass, changes no-op
Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: Id84ca2bee6f237877ba2900b2cbe4679b38a91dc
Diffstat (limited to 'redfish-core/include')
-rw-r--r-- | redfish-core/include/event_service_manager.hpp | 21 | ||||
-rw-r--r-- | redfish-core/include/gzfile.hpp | 2 |
2 files changed, 10 insertions, 13 deletions
diff --git a/redfish-core/include/event_service_manager.hpp b/redfish-core/include/event_service_manager.hpp index 6cb95c4c5c..e6e694f65d 100644 --- a/redfish-core/include/event_service_manager.hpp +++ b/redfish-core/include/event_service_manager.hpp @@ -663,7 +663,7 @@ class EventServiceManager } } - void loadOldBehavior() + static void loadOldBehavior() { std::ifstream eventConfigFile(eventServiceFile); if (!eventConfigFile.good()) @@ -1312,8 +1312,14 @@ class EventServiceManager } #endif - void getReadingsForReport(sdbusplus::message::message& msg) + static void getReadingsForReport(sdbusplus::message::message& msg) { + if (msg.is_method_error()) + { + BMCWEB_LOG_ERROR << "TelemetryMonitor Signal error"; + return; + } + sdbusplus::message::object_path path(msg.get_path()); std::string id = path.filename(); if (id.empty()) @@ -1380,16 +1386,7 @@ class EventServiceManager "arg0=xyz.openbmc_project.Telemetry.Report"; matchTelemetryMonitor = std::make_shared<sdbusplus::bus::match::match>( - *crow::connections::systemBus, matchStr, - [this](sdbusplus::message::message& msg) { - if (msg.is_method_error()) - { - BMCWEB_LOG_ERROR << "TelemetryMonitor Signal error"; - return; - } - - getReadingsForReport(msg); - }); + *crow::connections::systemBus, matchStr, getReadingsForReport); } }; diff --git a/redfish-core/include/gzfile.hpp b/redfish-core/include/gzfile.hpp index 567741dfd8..696b13c633 100644 --- a/redfish-core/include/gzfile.hpp +++ b/redfish-core/include/gzfile.hpp @@ -38,7 +38,7 @@ class GzFileReader std::string lastDelimiter; size_t totalFilesSize = 0; - void printErrorMessage(gzFile logStream) + static void printErrorMessage(gzFile logStream) { int errNum = 0; const char* errMsg = gzerror(logStream, &errNum); |