diff options
| author | Ed Tanous <ed@tanous.net> | 2020-07-25 22:02:03 +0300 |
|---|---|---|
| committer | Ed Tanous <ed@tanous.net> | 2020-08-17 23:54:37 +0300 |
| commit | cb13a39253848ece442971301ade9c09d98bf08e (patch) | |
| tree | 62f2a64fbc98d8ee635a0a81f3ef07afa541981d /redfish-core/lib/chassis.hpp | |
| parent | 23a21a1cbed23ace4174664950e595df961e9e69 (diff) | |
| download | bmcweb-cb13a39253848ece442971301ade9c09d98bf08e.tar.xz | |
Enable unused variable warnings and resolve
This commit enables the "unused variables" warning in clang. Throughout
this, it did point out several issues that would've been functional
bugs, so I think it was worthwhile. It also cleaned up several unused
variable from old constructs that no longer exist.
Tested:
Built with clang. Code no longer emits warnings.
Downloaded bmcweb to system and pulled up the webui, observed webui
loads and logs in properly.
Change-Id: I51505f4222cc147d6f2b87b14d7e2ac4a74cafa8
Signed-off-by: Ed Tanous <ed@tanous.net>
Diffstat (limited to 'redfish-core/lib/chassis.hpp')
| -rw-r--r-- | redfish-core/lib/chassis.hpp | 15 |
1 files changed, 10 insertions, 5 deletions
diff --git a/redfish-core/lib/chassis.hpp b/redfish-core/lib/chassis.hpp index 10b07980e0..c7db370830 100644 --- a/redfish-core/lib/chassis.hpp +++ b/redfish-core/lib/chassis.hpp @@ -175,8 +175,8 @@ class ChassisCollection : public Node /** * Functions triggers appropriate requests on DBus */ - void doGet(crow::Response& res, const crow::Request& req, - const std::vector<std::string>& params) override + void doGet(crow::Response& res, const crow::Request&, + const std::vector<std::string>&) override { res.jsonValue["@odata.type"] = "#ChassisCollection.ChassisCollection"; res.jsonValue["@odata.id"] = "/redfish/v1/Chassis"; @@ -242,7 +242,7 @@ class Chassis : public Node /** * Functions triggers appropriate requests on DBus */ - void doGet(crow::Response& res, const crow::Request& req, + void doGet(crow::Response& res, const crow::Request&, const std::vector<std::string>& params) override { const std::array<const char*, 2> interfaces = { @@ -356,6 +356,11 @@ class Chassis : public Node const boost::system::error_code ec2, const std::vector<std::pair< std::string, VariantType>>& propertiesList) { + if (ec2) + { + return; + } + for (const std::pair<std::string, VariantType>& property : propertiesList) { @@ -570,7 +575,7 @@ class ChassisResetAction : public Node * Analyzes POST body before sending Reset request data to D-Bus. */ void doPost(crow::Response& res, const crow::Request& req, - const std::vector<std::string>& params) override + const std::vector<std::string>&) override { BMCWEB_LOG_DEBUG << "Post Chassis Reset."; @@ -621,7 +626,7 @@ class ChassisResetActionInfo : public Node /** * Functions triggers appropriate requests on DBus */ - void doGet(crow::Response& res, const crow::Request& req, + void doGet(crow::Response& res, const crow::Request&, const std::vector<std::string>& params) override { if (params.size() != 1) |