diff options
| author | zhanghch05 <zhanghch05@inspur.com> | 2021-04-01 06:18:24 +0300 |
|---|---|---|
| committer | zhanghch05 <zhanghch05@inspur.com> | 2021-04-08 04:01:21 +0300 |
| commit | 8d1b46d7f8d39db2ba048f9e9007106ca3a28c9b (patch) | |
| tree | 821fcb9b383fdf3db22db77e154cd7f57606d402 /redfish-core/lib/telemetry_service.hpp | |
| parent | dab0604af234bdd5010407031a01343d6c242edf (diff) | |
| download | bmcweb-8d1b46d7f8d39db2ba048f9e9007106ca3a28c9b.tar.xz | |
Using AsyncResp everywhere
Get the core using AsyncResp everywhere, and not have each individual handler
creating its own object.We can call app.handle() without fear of the response
getting ended after the first tree is done populating.
Don't use res.end() anymore.
Tested:
1. Validator passed.
Signed-off-by: zhanghaicheng <zhanghch05@inspur.com>
Change-Id: I867367ce4a0caf8c4b3f4e07e06c11feed0782e8
Diffstat (limited to 'redfish-core/lib/telemetry_service.hpp')
| -rw-r--r-- | redfish-core/lib/telemetry_service.hpp | 17 |
1 files changed, 8 insertions, 9 deletions
diff --git a/redfish-core/lib/telemetry_service.hpp b/redfish-core/lib/telemetry_service.hpp index 61ca891dbd..9ec07379a4 100644 --- a/redfish-core/lib/telemetry_service.hpp +++ b/redfish-core/lib/telemetry_service.hpp @@ -23,21 +23,20 @@ class TelemetryService : public Node } private: - void doGet(crow::Response& res, const crow::Request&, - const std::vector<std::string>&) override + void doGet(const std::shared_ptr<bmcweb::AsyncResp>& asyncResp, + const crow::Request&, const std::vector<std::string>&) override { - res.jsonValue["@odata.type"] = + asyncResp->res.jsonValue["@odata.type"] = "#TelemetryService.v1_2_1.TelemetryService"; - res.jsonValue["@odata.id"] = "/redfish/v1/TelemetryService"; - res.jsonValue["Id"] = "TelemetryService"; - res.jsonValue["Name"] = "Telemetry Service"; + asyncResp->res.jsonValue["@odata.id"] = "/redfish/v1/TelemetryService"; + asyncResp->res.jsonValue["Id"] = "TelemetryService"; + asyncResp->res.jsonValue["Name"] = "Telemetry Service"; - res.jsonValue["MetricReportDefinitions"]["@odata.id"] = + asyncResp->res.jsonValue["MetricReportDefinitions"]["@odata.id"] = "/redfish/v1/TelemetryService/MetricReportDefinitions"; - res.jsonValue["MetricReports"]["@odata.id"] = + asyncResp->res.jsonValue["MetricReports"]["@odata.id"] = "/redfish/v1/TelemetryService/MetricReports"; - auto asyncResp = std::make_shared<AsyncResp>(res); crow::connections::systemBus->async_method_call( [asyncResp]( const boost::system::error_code ec, |