diff options
| author | Lei YU <yulei.sh@bytedance.com> | 2023-06-16 09:40:22 +0300 |
|---|---|---|
| committer | Patrick Williams <patrick@stwcx.xyz> | 2023-06-20 00:00:25 +0300 |
| commit | 88ed2737425cd800b27d1ff62069cf50207b87ee (patch) | |
| tree | a988eb98423cea74da40e40e22b4c3099e73187b | |
| parent | d9f44f7e2bf170831f0408234b820155cd10adbb (diff) | |
| download | openbmc-88ed2737425cd800b27d1ff62069cf50207b87ee.tar.xz | |
meta-phosphor: image-signing: Make script POSIX compliant
The script was comparing string with `==` that works in bash but not in
`dash`.
Change it to `=` so that it is more POSIX compliant.
Tested: Verify the build passes with SIGNING_PUBLIC_KEY defined with
both `bash` and `dash`.
Signed-off-by: Lei YU <yulei.sh@bytedance.com>
Change-Id: Id825cd111adeae5b1e50ea4f25603728cc122375
| -rw-r--r-- | meta-phosphor/classes/image_types_phosphor.bbclass | 2 | ||||
| -rw-r--r-- | meta-phosphor/recipes-phosphor/flash/phosphor-image-signing.bb | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/meta-phosphor/classes/image_types_phosphor.bbclass b/meta-phosphor/classes/image_types_phosphor.bbclass index 717c4536dc..63de40e266 100644 --- a/meta-phosphor/classes/image_types_phosphor.bbclass +++ b/meta-phosphor/classes/image_types_phosphor.bbclass @@ -356,7 +356,7 @@ do_generate_static[depends] += " \ make_signatures() { signing_key="${SIGNING_KEY}" - if [ "${INSECURE_KEY}" == "True" ] && [ -n "${SIGNING_PUBLIC_KEY}" ]; then + if [ "${INSECURE_KEY}" = "True" ] && [ -n "${SIGNING_PUBLIC_KEY}" ]; then echo "Using SIGNING_PUBLIC_KEY" signing_key="" fi diff --git a/meta-phosphor/recipes-phosphor/flash/phosphor-image-signing.bb b/meta-phosphor/recipes-phosphor/flash/phosphor-image-signing.bb index 09080bcee4..278cf35474 100644 --- a/meta-phosphor/recipes-phosphor/flash/phosphor-image-signing.bb +++ b/meta-phosphor/recipes-phosphor/flash/phosphor-image-signing.bb @@ -16,7 +16,7 @@ inherit allarch do_install() { signing_key="${SIGNING_KEY}" - if [ "${INSECURE_KEY}" == "True" ] && [ -n "${SIGNING_PUBLIC_KEY}" ]; then + if [ "${INSECURE_KEY}" = "True" ] && [ -n "${SIGNING_PUBLIC_KEY}" ]; then echo "Using SIGNING_PUBLIC_KEY" signing_key="" fi |