diff options
| author | Thang Q. Nguyen <thang@os.amperecomputing.com> | 2023-04-07 12:26:32 +0300 |
|---|---|---|
| committer | Thang Q. Nguyen <thang@os.amperecomputing.com> | 2023-04-10 04:41:27 +0300 |
| commit | 90e792a45ac1ca2fbd237df40212308abe90c09f (patch) | |
| tree | d97171c6b0cef29672e42f0443727424480544cd /meta-ampere/meta-jade/recipes-phosphor | |
| parent | d1d733b5bc0348de3752efeed45d1218cde62f37 (diff) | |
| download | openbmc-90e792a45ac1ca2fbd237df40212308abe90c09f.tar.xz | |
meta-ampere: remove env call from service file
We are suppose to use direct executable calls in service files
rather than indirections through /bin/env (See Anti-patterns).
Tested:
- Check related services to work like before
Signed-off-by: Thang Q. Nguyen <thang@os.amperecomputing.com>
Change-Id: Idb494ce781fa1bdcac176cd89612e6016e6e04d9
Diffstat (limited to 'meta-ampere/meta-jade/recipes-phosphor')
4 files changed, 4 insertions, 4 deletions
diff --git a/meta-ampere/meta-jade/recipes-phosphor/gpio/phosphor-gpio-monitor/ampere-host-shutdown-ack@.service b/meta-ampere/meta-jade/recipes-phosphor/gpio/phosphor-gpio-monitor/ampere-host-shutdown-ack@.service index 6588191aae..0f9809d4bc 100644 --- a/meta-ampere/meta-jade/recipes-phosphor/gpio/phosphor-gpio-monitor/ampere-host-shutdown-ack@.service +++ b/meta-ampere/meta-jade/recipes-phosphor/gpio/phosphor-gpio-monitor/ampere-host-shutdown-ack@.service @@ -4,5 +4,5 @@ Conflicts=obmc-chassis-poweron@0.target [Service] Type=oneshot -ExecStart=/usr/bin/env ampere_power_util.sh mb shutdown_ack +ExecStart=/usr/sbin/ampere_power_util.sh mb shutdown_ack SyslogIdentifier=ampere_host_shutdown_ack diff --git a/meta-ampere/meta-jade/recipes-phosphor/gpio/phosphor-gpio-monitor/ampere_hightemp_start@.service b/meta-ampere/meta-jade/recipes-phosphor/gpio/phosphor-gpio-monitor/ampere_hightemp_start@.service index 5f26194eb0..ff11d6ec26 100644 --- a/meta-ampere/meta-jade/recipes-phosphor/gpio/phosphor-gpio-monitor/ampere_hightemp_start@.service +++ b/meta-ampere/meta-jade/recipes-phosphor/gpio/phosphor-gpio-monitor/ampere_hightemp_start@.service @@ -3,4 +3,4 @@ Description=Ampere Computing LLC HighTempt event [Service] Restart=no -ExecStart=/usr/bin/env ampere_add_redfishevent.sh OpenBMC.0.1.AmpereEvent.Warning "CPU%i HighTemp asserted" +ExecStart=/usr/sbin/ampere_add_redfishevent.sh OpenBMC.0.1.AmpereEvent.Warning "CPU%i HighTemp asserted" diff --git a/meta-ampere/meta-jade/recipes-phosphor/gpio/phosphor-gpio-monitor/ampere_hightemp_stop@.service b/meta-ampere/meta-jade/recipes-phosphor/gpio/phosphor-gpio-monitor/ampere_hightemp_stop@.service index 012b0ddaf9..16d372db1e 100644 --- a/meta-ampere/meta-jade/recipes-phosphor/gpio/phosphor-gpio-monitor/ampere_hightemp_stop@.service +++ b/meta-ampere/meta-jade/recipes-phosphor/gpio/phosphor-gpio-monitor/ampere_hightemp_stop@.service @@ -3,4 +3,4 @@ Description=Ampere Computing LLC HighTempt event [Service] Restart=no -ExecStart=/usr/bin/env ampere_add_redfishevent.sh OpenBMC.0.1.AmpereEvent.OK "CPU%i HighTemp deasserted" +ExecStart=/usr/sbin/ampere_add_redfishevent.sh OpenBMC.0.1.AmpereEvent.OK "CPU%i HighTemp deasserted" diff --git a/meta-ampere/meta-jade/recipes-phosphor/gpio/phosphor-gpio-monitor/ampere_scp_failover.service b/meta-ampere/meta-jade/recipes-phosphor/gpio/phosphor-gpio-monitor/ampere_scp_failover.service index ff4dec57a3..627a8e4089 100644 --- a/meta-ampere/meta-jade/recipes-phosphor/gpio/phosphor-gpio-monitor/ampere_scp_failover.service +++ b/meta-ampere/meta-jade/recipes-phosphor/gpio/phosphor-gpio-monitor/ampere_scp_failover.service @@ -3,4 +3,4 @@ Description=Ampere Computing LLC Ampere failover event service [Service] Restart=no -ExecStart=/usr/bin/env ampere_scp_failover.sh +ExecStart=/usr/sbin/ampere_scp_failover.sh |