summaryrefslogtreecommitdiff
path: root/meta-ampere/meta-mitchell
diff options
context:
space:
mode:
authorPatrick Williams <patrick@stwcx.xyz>2023-04-17 00:41:45 +0300
committerPatrick Williams <patrick@stwcx.xyz>2023-04-17 17:55:24 +0300
commit0731ef898f1388a63cdb57dcdeda4c2f04c06447 (patch)
tree3cfc9a7589823412ac596f578fba4e60072151a7 /meta-ampere/meta-mitchell
parent69b4c107a643db8ba310af35c2cf74a75220e25b (diff)
downloadopenbmc-0731ef898f1388a63cdb57dcdeda4c2f04c06447.tar.xz
meta-ampere: shellcheck: fix up source locations
Many scripts in meta-ampere had `shellcheck source=/dev/null`, which isn't as useful as putting the real sourced script. Fix up all of these in the meta-layer to point to the right script, which as a side-effect allow a few global-disables to be removed. Signed-off-by: Patrick Williams <patrick@stwcx.xyz> Change-Id: Icb43dc76a19edbdada8b4caa6ced57ff07f42d27
Diffstat (limited to 'meta-ampere/meta-mitchell')
-rw-r--r--meta-ampere/meta-mitchell/recipes-ampere/host/ampere-sysfw-hang-handler/ampere_sysfw_hang_handler.sh4
-rw-r--r--meta-ampere/meta-mitchell/recipes-ampere/platform/ampere-platform-init/ampere_bmc_heartbeat.sh4
-rw-r--r--meta-ampere/meta-mitchell/recipes-ampere/platform/ampere-platform-init/ampere_platform_init.sh5
-rw-r--r--meta-ampere/meta-mitchell/recipes-ampere/platform/ampere-platform-init/gpio-lib.sh5
-rw-r--r--meta-ampere/meta-mitchell/recipes-ampere/platform/ampere-platform-init/mtmitchell_platform_gpios_init.sh4
-rw-r--r--meta-ampere/meta-mitchell/recipes-ampere/platform/ampere-utils/ampere_power_util.sh4
6 files changed, 7 insertions, 19 deletions
diff --git a/meta-ampere/meta-mitchell/recipes-ampere/host/ampere-sysfw-hang-handler/ampere_sysfw_hang_handler.sh b/meta-ampere/meta-mitchell/recipes-ampere/host/ampere-sysfw-hang-handler/ampere_sysfw_hang_handler.sh
index c3f77fd8b1..9c36df23df 100644
--- a/meta-ampere/meta-mitchell/recipes-ampere/host/ampere-sysfw-hang-handler/ampere_sysfw_hang_handler.sh
+++ b/meta-ampere/meta-mitchell/recipes-ampere/host/ampere-sysfw-hang-handler/ampere_sysfw_hang_handler.sh
@@ -1,8 +1,6 @@
#!/bin/bash
-# shellcheck disable=SC2046
-# shellcheck source=/dev/null
-
+# shellcheck source=meta-ampere/meta-mitchell/recipes-ampere/platform/ampere-platform-init/gpio-lib.sh
source /usr/sbin/gpio-lib.sh
# Do event trigger
diff --git a/meta-ampere/meta-mitchell/recipes-ampere/platform/ampere-platform-init/ampere_bmc_heartbeat.sh b/meta-ampere/meta-mitchell/recipes-ampere/platform/ampere-platform-init/ampere_bmc_heartbeat.sh
index 5ecea31e6c..b9bba7b0f1 100644
--- a/meta-ampere/meta-mitchell/recipes-ampere/platform/ampere-platform-init/ampere_bmc_heartbeat.sh
+++ b/meta-ampere/meta-mitchell/recipes-ampere/platform/ampere-platform-init/ampere_bmc_heartbeat.sh
@@ -1,8 +1,6 @@
#!/bin/bash
-# shellcheck disable=SC2154
-# shellcheck source=/dev/null
-
+# shellcheck source=meta-ampere/meta-mitchell/recipes-ampere/platform/ampere-platform-init/gpio-lib.sh
source /usr/sbin/gpio-lib.sh
value=0
diff --git a/meta-ampere/meta-mitchell/recipes-ampere/platform/ampere-platform-init/ampere_platform_init.sh b/meta-ampere/meta-mitchell/recipes-ampere/platform/ampere-platform-init/ampere_platform_init.sh
index 33dc7ea16a..9d6ca0e2a7 100644
--- a/meta-ampere/meta-mitchell/recipes-ampere/platform/ampere-platform-init/ampere_platform_init.sh
+++ b/meta-ampere/meta-mitchell/recipes-ampere/platform/ampere-platform-init/ampere_platform_init.sh
@@ -1,9 +1,8 @@
#!/bin/bash
-# shellcheck disable=SC2154
-# shellcheck source=/dev/null
-
+# shellcheck source=meta-ampere/meta-mitchell/recipes-ampere/platform/ampere-platform-init/gpio-lib.sh
source /usr/sbin/gpio-lib.sh
+# shellcheck source=meta-ampere/meta-mitchell/recipes-ampere/platform/ampere-platform-init/mtmitchell_platform_gpios_init.sh
source /usr/sbin/platform_gpios_init.sh
#pre platform init function. implemented in platform_gpios_init.sh
diff --git a/meta-ampere/meta-mitchell/recipes-ampere/platform/ampere-platform-init/gpio-lib.sh b/meta-ampere/meta-mitchell/recipes-ampere/platform/ampere-platform-init/gpio-lib.sh
index 3e503c4909..5fbbbcc0d4 100644
--- a/meta-ampere/meta-mitchell/recipes-ampere/platform/ampere-platform-init/gpio-lib.sh
+++ b/meta-ampere/meta-mitchell/recipes-ampere/platform/ampere-platform-init/gpio-lib.sh
@@ -1,8 +1,5 @@
#!/bin/bash
-# shellcheck disable=SC2154
-# shellcheck source=/dev/null
-
# Configure GPIO as output and set its value
AST2600_GPIO_BASE=(
816
@@ -69,4 +66,4 @@ function gpio_name_input()
gpioPin=$(("$offset" + ${AST2600_GPIO_BASE[$gpioid]}))
gpio_configure_input "$gpioPin"
fi
-} \ No newline at end of file
+}
diff --git a/meta-ampere/meta-mitchell/recipes-ampere/platform/ampere-platform-init/mtmitchell_platform_gpios_init.sh b/meta-ampere/meta-mitchell/recipes-ampere/platform/ampere-platform-init/mtmitchell_platform_gpios_init.sh
index 76d3a7454c..65acfc5f15 100644
--- a/meta-ampere/meta-mitchell/recipes-ampere/platform/ampere-platform-init/mtmitchell_platform_gpios_init.sh
+++ b/meta-ampere/meta-mitchell/recipes-ampere/platform/ampere-platform-init/mtmitchell_platform_gpios_init.sh
@@ -1,8 +1,6 @@
#!/bin/bash
-# shellcheck disable=SC2154
-# shellcheck source=/dev/null
-
+# shellcheck source=meta-ampere/meta-mitchell/recipes-ampere/platform/ampere-platform-init/gpio-lib.sh
source /usr/sbin/gpio-lib.sh
function bind_rtc_driver() {
diff --git a/meta-ampere/meta-mitchell/recipes-ampere/platform/ampere-utils/ampere_power_util.sh b/meta-ampere/meta-mitchell/recipes-ampere/platform/ampere-utils/ampere_power_util.sh
index 6f799f03f2..fb5be7ff35 100644
--- a/meta-ampere/meta-mitchell/recipes-ampere/platform/ampere-utils/ampere_power_util.sh
+++ b/meta-ampere/meta-mitchell/recipes-ampere/platform/ampere-utils/ampere_power_util.sh
@@ -1,8 +1,6 @@
#!/bin/bash
-# shellcheck disable=SC2046
-# shellcheck source=/dev/null
-
+# shellcheck source=meta-ampere/meta-mitchell/recipes-ampere/platform/ampere-platform-init/gpio-lib.sh
source /usr/sbin/gpio-lib.sh
# Usage of this utility