diff options
| author | Joel Stanley <joel@jms.id.au> | 2021-12-02 04:13:37 +0300 |
|---|---|---|
| committer | Patrick Williams <patrick@stwcx.xyz> | 2022-08-09 06:48:54 +0300 |
| commit | c1e7bf3464b0c69da062633aca82625d8895310f (patch) | |
| tree | 09a13794cb28947e0a200c006db1cad57ffa4822 /meta-phosphor/recipes-phosphor/dump | |
| parent | 47bae0ce31520244d216e681d6f9bc96dcf30200 (diff) | |
| download | openbmc-c1e7bf3464b0c69da062633aca82625d8895310f.tar.xz | |
phosphor: debug-collector: Limit collection to oops
Currently we trigger the phosphor-debug-collector application to create
a dump whenever a file is present in the pstore directory. This means we
create a dump if eg. a console or ftrace log is captured by ramoops,
which is not indicative of an error.
For example, this is the content of the ramoops filesystem after a
normal reboot followed by a crash:
console-ramoops-0 dmesg-ramoops-0 dmesg-ramoops-1
Change to ConditionPathExistsGlob and look for anything with the pattern
dmesg-ramoops-*.
This is a better fix for the workaround implemented in 17e10e646324
("meta-ibm:pstore: remove console from ramoops"), allowing systems to
collect more traces without invoking a dump.
Change-Id: If1d93ee86a2cfb7f0902989cb78d128e82578402
Signed-off-by: Joel Stanley <joel@jms.id.au>
Diffstat (limited to 'meta-phosphor/recipes-phosphor/dump')
| -rw-r--r-- | meta-phosphor/recipes-phosphor/dump/phosphor-debug-collector/ramoops-monitor.service | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/meta-phosphor/recipes-phosphor/dump/phosphor-debug-collector/ramoops-monitor.service b/meta-phosphor/recipes-phosphor/dump/phosphor-debug-collector/ramoops-monitor.service index efb95c39ea..7ae5ed9fd9 100644 --- a/meta-phosphor/recipes-phosphor/dump/phosphor-debug-collector/ramoops-monitor.service +++ b/meta-phosphor/recipes-phosphor/dump/phosphor-debug-collector/ramoops-monitor.service @@ -1,6 +1,6 @@ [Unit] Description=Ramoops monitor. -ConditionPathExists=/var/lib/systemd/pstore +ConditionPathExistsGlob=/var/lib/systemd/pstore/dmesg-ramoops-* After=xyz.openbmc_project.Dump.Manager.service [Service] |