| Age | Commit message (Collapse) | Author | Files | Lines |
|---|
|
Use meson to build the package.
This change required as a part of privilege separation work:
https://github.com/openbmc/openbmc/issues/3383
This change should be merged after individual repo change:
https://gerrit.openbmc-project.xyz/c/openbmc/phosphor-hwmon/+/40277
Signed-off-by: Anton D. Kachalov <gmouse@google.com>
Change-Id: I542645d55b8646e0ddb3fb95f50a1cd87334706e
|
|
We aren't correctly escaping all of the specical characters based on the
systemd spec for unit name escaping. systemd provides a utility to do
this reliably, so use that instead of a custom implementation.
(From meta-phosphor rev: e1acbce6ac818e411cee8483c89ea6f7b0829162)
Change-Id: I239f396f92e6a6b94edcfe48084c41dcc292e1b7
Signed-off-by: William A. Kennington III <wak@google.com>
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
If we create a dependency in the hwmon service that makes it take extra
time to start, this will block up all of udev and prevent other devices
from being discovered as we wait on the specific hwmon instance to
start. This can result in deadlocks.
Typical convention in udev is to block as little as possible to avoid
these type of scenarios. udev can't handle failures so it's pointless to
wait anyway. The service start will still be queued up as expected.
Tested:
Ran on a machine configured to use hwmon. Configured sensors can
still be read and the daemons start as expected.
(From meta-phosphor rev: 1a21d0092ab2f07f5530f8b1167cbe5af12b9516)
Change-Id: I358566ce124a2bcd44306df3d579beca65133e83
Signed-off-by: William A. Kennington III <wak@google.com>
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
Still chasing root cause of openbmc/openbmc#3466 but either way, these
services should be configured to only ever run once. They do one-time
things and do not make sense to be run multiple times.
(From meta-phosphor rev: d9c5bebf10b7e45c714c072a12d058be683d4b18)
Change-Id: If199ed739853b353cb11c85039a30c17e9a32e49
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
On P9 the occ device has `:` in path, and it needs to be converted to
`--` while starting hwmon service.
The commit 2f714db14 accidentally removes the convertion, and cause P9's
occ hwmon sensor are not started.
This commit fixes the issue by converting `:` to `--` first.
Tested: Verify the occ hwmon sensors are started on Romulus
(From meta-phosphor rev: b9f0f689b1b86f3415c83bb3bace0c0f78ea65b0)
Change-Id: If7a1cf91fdde31ed83db99fa16553cc5577bad82
Signed-off-by: Lei YU <mine260309@gmail.com>
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
After the commit 7ead6495b6d6782dd89951e8bfb26131f35863ec
the phosphor-hwmon failed to start with errors like this:
```
/lib/systemd/system/xyz.openbmc_project.Hwmon@.service:8:
Failed to resolve unit specifiers on %f: Invalid argument
```
It happens when the instance name begins with `/` character which causes
this error when used specifier `%f`.
Besides the specifier `%I` looks less buggy and more appropriate in this
case, because it's the only part of path and will be completed inside
the `phosphor-hwmon-readd`.
This commit fixes the starting of the phosphor-hwmon.
Partially resolves: openbmc/openbmc#3435
(From meta-phosphor rev: a87fb2d1eb682ed0f04e0f269966b9ae4aafbb1e)
Change-Id: Ia8185f047f23bdcd9141d7edea47ad50e6f7fe07
Signed-off-by: Alexander Filippov <a.filippov@yadro.com>
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
Adopt a more conventional directory hierarchy. meta-phosphor is still
a _long_ way from suitable for hosting on yoctoproject.org but things
like this don't help.
(From meta-phosphor rev: 471cfcefa74b8c7ceb704cb670e6d915cf27c63b)
Change-Id: I3f106b2f6cdc6cec734be28a6090800546f362eb
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
