diff options
| author | Ed Tanous <ed@tanous.net> | 2024-04-21 02:36:26 +0300 |
|---|---|---|
| committer | Ed Tanous <ed@tanous.net> | 2024-04-24 20:21:02 +0300 |
| commit | 51abe87feea7261ec6f7589d8214af3d8019e71e (patch) | |
| tree | c3d16367cccea7047263596005c00318753eaf89 | |
| parent | 515f46565a93f71ecd8b683198797b1690d3b5f8 (diff) | |
| download | webui-vue-51abe87feea7261ec6f7589d8214af3d8019e71e.tar.xz | |
Inline the header svg
Ideally we wouldn't have to pull down this file on every load, and we
could just inline it. This commit implements inlining. Note, that
this requires a minor modification to the unit test, as the inline
header remains when unit tests are run. It's not clear at this time
how to make inlining plugin operate on unit tests, but it doesn't seem
terribly important.
Tested: Loading the webui no longer shows a download of logo-header
Change-Id: Iaa5be5b5a84e0ad6e1f430113f929032835c9f1c
Signed-off-by: Ed Tanous <ed@tanous.net>
| -rw-r--r-- | src/components/AppHeader/AppHeader.vue | 1 | ||||
| -rw-r--r-- | tests/unit/__snapshots__/AppHeader.spec.js.snap | 1 |
2 files changed, 2 insertions, 0 deletions
diff --git a/src/components/AppHeader/AppHeader.vue b/src/components/AppHeader/AppHeader.vue index 5cda341e..76c96c06 100644 --- a/src/components/AppHeader/AppHeader.vue +++ b/src/components/AppHeader/AppHeader.vue @@ -36,6 +36,7 @@ data-test-id="appHeader-container-overview" > <img + svg-inline class="header-logo" src="@/assets/images/logo-header.svg" :alt="altLogo" diff --git a/tests/unit/__snapshots__/AppHeader.spec.js.snap b/tests/unit/__snapshots__/AppHeader.spec.js.snap index 1ad2b3d6..b5e12228 100644 --- a/tests/unit/__snapshots__/AppHeader.spec.js.snap +++ b/tests/unit/__snapshots__/AppHeader.spec.js.snap @@ -57,6 +57,7 @@ exports[`AppHeader.vue should render correctly 1`] = ` alt="Built on OpenBMC" class="header-logo" src="@/assets/images/logo-header.svg" + svg-inline="" /> </b-navbar-brand> |