diff options
| author | Ian Rogers <irogers@google.com> | 2024-02-09 23:49:46 +0300 |
|---|---|---|
| committer | Namhyung Kim <namhyung@kernel.org> | 2024-02-14 00:48:09 +0300 |
| commit | 2543947c77e0e224bda86b4e7220c2f6714da463 (patch) | |
| tree | 55d5336fe0a051fe5b0b8b6c2b87bea76a36d9c4 | |
| parent | 6dd76680b925228312756c13b9b983661b552a64 (diff) | |
| download | linux-2543947c77e0e224bda86b4e7220c2f6714da463.tar.xz | |
perf stat: Avoid metric-only segv
Cycles is recognized as part of a hard coded metric in stat-shadow.c,
it may call print_metric_only with a NULL fmt string leading to a
segfault. Handle the NULL fmt explicitly.
Fixes: 088519f318be ("perf stat: Move the display functions to stat-display.c")
Signed-off-by: Ian Rogers <irogers@google.com>
Reviewed-by: Kan Liang <kan.liang@linux.intel.com>
Cc: K Prateek Nayak <kprateek.nayak@amd.com>
Cc: James Clark <james.clark@arm.com>
Cc: Kaige Ye <ye@kaige.org>
Cc: John Garry <john.g.garry@oracle.com>
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Link: https://lore.kernel.org/r/20240209204947.3873294-4-irogers@google.com
| -rw-r--r-- | tools/perf/util/stat-display.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tools/perf/util/stat-display.c b/tools/perf/util/stat-display.c index 4dfe7d9517a9..ae37395f90c0 100644 --- a/tools/perf/util/stat-display.c +++ b/tools/perf/util/stat-display.c @@ -571,7 +571,7 @@ static void print_metric_only(struct perf_stat_config *config, if (color) mlen += strlen(color) + sizeof(PERF_COLOR_RESET) - 1; - color_snprintf(str, sizeof(str), color ?: "", fmt, val); + color_snprintf(str, sizeof(str), color ?: "", fmt ?: "", val); fprintf(out, "%*s ", mlen, str); os->first = false; } |