diff options
| author | Takashi Iwai <tiwai@suse.de> | 2020-03-11 11:02:06 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2020-03-11 11:08:44 +0300 |
| commit | 4636a04630f632262e915f62deb59fa0f3ee5186 (patch) | |
| tree | c803619e53fe914ecaa505c5d47f1927015a7926 /drivers/base/cpu.c | |
| parent | 9a2dd570591ea1d53284208ab8838c0ab2a08340 (diff) | |
| download | linux-4636a04630f632262e915f62deb59fa0f3ee5186.tar.xz | |
drivers/base/cpu: Use scnprintf() for avoiding potential buffer overflow
Since snprintf() returns the would-be-output size instead of the
actual output size, the succeeding calls may go beyond the given
buffer limit. Fix it by replacing with scnprintf().
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Link: https://lore.kernel.org/r/20200311080207.12046-2-tiwai@suse.de
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/base/cpu.c')
| -rw-r--r-- | drivers/base/cpu.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/base/cpu.c b/drivers/base/cpu.c index 6265871a4af2..67aaa052c7a2 100644 --- a/drivers/base/cpu.c +++ b/drivers/base/cpu.c @@ -258,13 +258,13 @@ static ssize_t print_cpus_offline(struct device *dev, buf[n++] = ','; if (nr_cpu_ids == total_cpus-1) - n += snprintf(&buf[n], len - n, "%u", nr_cpu_ids); + n += scnprintf(&buf[n], len - n, "%u", nr_cpu_ids); else - n += snprintf(&buf[n], len - n, "%u-%d", + n += scnprintf(&buf[n], len - n, "%u-%d", nr_cpu_ids, total_cpus-1); } - n += snprintf(&buf[n], len - n, "\n"); + n += scnprintf(&buf[n], len - n, "\n"); return n; } static DEVICE_ATTR(offline, 0444, print_cpus_offline, NULL); |