diff options
| author | Uwe Kleine-König <u.kleine-koenig@pengutronix.de> | 2023-04-06 11:23:54 +0300 |
|---|---|---|
| committer | Wolfram Sang <wsa@kernel.org> | 2023-04-13 19:47:13 +0300 |
| commit | 9496fffcb28f39e0352779a0199b6e61861c9221 (patch) | |
| tree | 8a1fd5dd5d7a8f1c3cc46991fd15534da42195b9 /drivers/i2c | |
| parent | 0cbc9a2c62d2674b078d84e8f40445d755b94c30 (diff) | |
| download | linux-9496fffcb28f39e0352779a0199b6e61861c9221.tar.xz | |
i2c: omap: Improve error reporting for problems during .remove()
If pm_runtime_get() fails in .remove() the driver used to return the
error to the driver core. The only effect of this (compared to returning
zero) is a generic warning that the error value is ignored.
So emit a better warning and return zero to suppress the generic (and
little helpful) message. Also disable runtime PM in the error case.
This prepares changing platform device remove callbacks to return void.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Tony Lindgren <tony@atomide.com>
Signed-off-by: Wolfram Sang <wsa@kernel.org>
Diffstat (limited to 'drivers/i2c')
| -rw-r--r-- | drivers/i2c/busses/i2c-omap.c | 9 |
1 files changed, 6 insertions, 3 deletions
diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c index f9ae520aed22..2b4e2be51318 100644 --- a/drivers/i2c/busses/i2c-omap.c +++ b/drivers/i2c/busses/i2c-omap.c @@ -1525,14 +1525,17 @@ static int omap_i2c_remove(struct platform_device *pdev) int ret; i2c_del_adapter(&omap->adapter); - ret = pm_runtime_resume_and_get(&pdev->dev); + + ret = pm_runtime_get_sync(&pdev->dev); if (ret < 0) - return ret; + dev_err(omap->dev, "Failed to resume hardware, skip disable\n"); + else + omap_i2c_write_reg(omap, OMAP_I2C_CON_REG, 0); - omap_i2c_write_reg(omap, OMAP_I2C_CON_REG, 0); pm_runtime_dont_use_autosuspend(&pdev->dev); pm_runtime_put_sync(&pdev->dev); pm_runtime_disable(&pdev->dev); + return 0; } |