summaryrefslogtreecommitdiff
path: root/drivers/irqchip/irq-loongson-pch-pic.c
diff options
context:
space:
mode:
authorMarc Zyngier <maz@kernel.org>2022-08-08 13:50:20 +0300
committerMarc Zyngier <maz@kernel.org>2022-08-09 08:54:05 +0300
commit7e4fd7a1a6fdf23d069eeb0ae0e8e46b9fb40723 (patch)
treec3a1b02d13d3ee1a6de2eadb15d19501413a7882 /drivers/irqchip/irq-loongson-pch-pic.c
parentfda7409a8fcfa457814f8186f2861a9f00008e75 (diff)
downloadlinux-7e4fd7a1a6fdf23d069eeb0ae0e8e46b9fb40723.tar.xz
irqchip/loongarch: Fix irq_domain_alloc_fwnode() abuse
The recently merged LoongArch drivers paper over the lack of topology information by creating a bunch of fwnodes for the irqchips. So far, so good. However, irq_domain_alloc_fwnode() is supposed to take a PA, and not a kernel VA blindly cast as a PA, potentially disclosing kernel VAs to userspace. In some other cases, even NULL is used as the PA, which is entertaining. Fix this by using the actual PA of the block when available, and switch to a named fwnode in the other cases. Signed-off-by: Marc Zyngier <maz@kernel.org> Reviewed-by: Jianmin Lv <lvjianmin@loongson.cn> Link: https://lore.kernel.org/r/20220808105020.2689757-1-maz@kernel.org
Diffstat (limited to 'drivers/irqchip/irq-loongson-pch-pic.c')
-rw-r--r--drivers/irqchip/irq-loongson-pch-pic.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/irqchip/irq-loongson-pch-pic.c b/drivers/irqchip/irq-loongson-pch-pic.c
index b987b6517d59..c01b9c257005 100644
--- a/drivers/irqchip/irq-loongson-pch-pic.c
+++ b/drivers/irqchip/irq-loongson-pch-pic.c
@@ -349,7 +349,7 @@ int __init pch_pic_acpi_init(struct irq_domain *parent,
vec_base = acpi_pchpic->gsi_base - GSI_MIN_PCH_IRQ;
- domain_handle = irq_domain_alloc_fwnode((phys_addr_t *)acpi_pchpic);
+ domain_handle = irq_domain_alloc_fwnode(&acpi_pchpic->address);
if (!domain_handle) {
pr_err("Unable to allocate domain handle\n");
return -ENOMEM;