summaryrefslogtreecommitdiff
path: root/drivers/net
diff options
context:
space:
mode:
authorOliver Hartkopp <socketcan@hartkopp.net>2023-01-04 17:57:01 +0300
committerMarc Kleine-Budde <mkl@pengutronix.de>2023-02-02 12:33:26 +0300
commit4f027cba8216f42a18b544842efab134f8b1f9f4 (patch)
tree89f1dd175d9056b0c11902be72600498a479b270 /drivers/net
parent823b2e42720f96f277940c37ea438b7c5ead51a4 (diff)
downloadlinux-4f027cba8216f42a18b544842efab134f8b1f9f4.tar.xz
can: isotp: split tx timer into transmission and timeout
The timer for the transmission of isotp PDUs formerly had two functions: 1. send two consecutive frames with a given time gap 2. monitor the timeouts for flow control frames and the echo frames This led to larger txstate checks and potentially to a problem discovered by syzbot which enabled the panic_on_warn feature while testing. The former 'txtimer' function is split into 'txfrtimer' and 'txtimer' to handle the two above functionalities with separate timer callbacks. The two simplified timers now run in one-shot mode and make the state transitions (especially with isotp_rcv_echo) better understandable. Fixes: 866337865f37 ("can: isotp: fix tx state handling for echo tx processing") Reported-by: syzbot+5aed6c3aaba661f5b917@syzkaller.appspotmail.com Cc: stable@vger.kernel.org # >= v6.0 Signed-off-by: Oliver Hartkopp <socketcan@hartkopp.net> Link: https://lore.kernel.org/all/20230104145701.2422-1-socketcan@hartkopp.net Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
Diffstat (limited to 'drivers/net')
0 files changed, 0 insertions, 0 deletions