diff options
| author | Fabrice Gasnier <fabrice.gasnier@foss.st.com> | 2022-07-13 16:39:53 +0300 |
|---|---|---|
| committer | Vinod Koul <vkoul@kernel.org> | 2022-07-15 14:34:25 +0300 |
| commit | 32b378a9179ae4db61cfc5d502717214e6cd1e1c (patch) | |
| tree | 1e4d4facee6a8d161622f5de70d0250ec6b2d423 /drivers/phy/st | |
| parent | 08fd292fdffcf5fbca6301ff43aa1ad3cf9d69da (diff) | |
| download | linux-32b378a9179ae4db61cfc5d502717214e6cd1e1c.tar.xz | |
phy: stm32: fix error return in stm32_usbphyc_phy_init
Error code is overridden, in case the PLL doesn't lock. So, the USB
initialization can continue. This leads to a platform freeze.
This can be avoided by returning proper error code to avoid USB probe
freezing the platform. It also displays proper errors in log.
Fixes: 5b1af71280ab ("phy: stm32: rework PLL Lock detection")
Signed-off-by: Fabrice Gasnier <fabrice.gasnier@foss.st.com>
Link: https://lore.kernel.org/r/20220713133953.595134-1-fabrice.gasnier@foss.st.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Diffstat (limited to 'drivers/phy/st')
| -rw-r--r-- | drivers/phy/st/phy-stm32-usbphyc.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/phy/st/phy-stm32-usbphyc.c b/drivers/phy/st/phy-stm32-usbphyc.c index 007a23c78d56..a98c911cc37a 100644 --- a/drivers/phy/st/phy-stm32-usbphyc.c +++ b/drivers/phy/st/phy-stm32-usbphyc.c @@ -358,7 +358,9 @@ static int stm32_usbphyc_phy_init(struct phy *phy) return 0; pll_disable: - return stm32_usbphyc_pll_disable(usbphyc); + stm32_usbphyc_pll_disable(usbphyc); + + return ret; } static int stm32_usbphyc_phy_exit(struct phy *phy) |