summaryrefslogtreecommitdiff
path: root/drivers/usb/musb/musb_dsps.c
diff options
context:
space:
mode:
authorSuwan Kim <suwan.kim027@gmail.com>2019-11-11 17:10:35 +0300
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2019-11-13 13:53:11 +0300
commit2a9125317b247f2cf35c196f968906dcf062ae2d (patch)
tree3b883ede04e3cb83c2ab3d27dd023ca9638387a8 /drivers/usb/musb/musb_dsps.c
parent1ec13abac58b6f24e32f0d3081ef4e7456e62ed8 (diff)
downloadlinux-2a9125317b247f2cf35c196f968906dcf062ae2d.tar.xz
usbip: Fix uninitialized symbol 'nents' in stub_recv_cmd_submit()
Smatch reported that nents is not initialized and used in stub_recv_cmd_submit(). nents is currently initialized by sgl_alloc() and used to allocate multiple URBs when host controller doesn't support scatter-gather DMA. The use of uninitialized nents means that buf_len is zero and use_sg is true. But buffer length should not be zero when an URB uses scatter-gather DMA. To prevent this situation, add the conditional that checks buf_len and use_sg. And move the use of nents right after the sgl_alloc() to avoid the use of uninitialized nents. If the error occurs, it adds SDEV_EVENT_ERROR_MALLOC and stub_priv will be released by stub event handler and connection will be shut down. Fixes: ea44d190764b ("usbip: Implement SG support to vhci-hcd and stub driver") Reported-by: kbuild test robot <lkp@intel.com> Reported-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Suwan Kim <suwan.kim027@gmail.com> Acked-by: Shuah Khan <skhan@linuxfoundation.org> Cc: stable <stable@vger.kernel.org> Link: https://lore.kernel.org/r/20191111141035.27788-1-suwan.kim027@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/usb/musb/musb_dsps.c')
0 files changed, 0 insertions, 0 deletions