diff options
| author | Srinivas Neeli <srinivas.neeli@amd.com> | 2023-08-30 13:28:25 +0300 |
|---|---|---|
| committer | Wim Van Sebroeck <wim@linux-watchdog.org> | 2023-10-11 19:53:33 +0300 |
| commit | 15f0f6d2ee05392ce05244a1aadc8b564099672d (patch) | |
| tree | 60877bf2a4bf2143dd1bc261f1383147a0ed73fc /drivers/watchdog/marvell_gti_wdt.c | |
| parent | bdb970186d156eb596f8f16f6e8467cdd5d57a70 (diff) | |
| download | linux-15f0f6d2ee05392ce05244a1aadc8b564099672d.tar.xz | |
watchdog: of_xilinx_wdt: Remove unnecessary clock disable call in the remove path
There is a mismatch in axi clock enable and disable calls.
The axi clock is enabled and disabled by the probe function,
then it is again disabled in the remove path.
So observed the call trace while removing the module.
Use the clk_enable() and devm_clk_get_prepared() functions
instead of devm_clk_get_enable() to avoid an extra clock disable
call from the remove path.
Call trace:
clk_core_disable+0xb0/0xc0
clk_disable+0x30/0x4c
clk_disable_unprepare+0x18/0x30
devm_clk_release+0x24/0x40
devres_release_all+0xc8/0x190
device_unbind_cleanup+0x18/0x6c
device_release_driver_internal+0x20c/0x250
device_release_driver+0x18/0x24
bus_remove_device+0x124/0x130
device_del+0x174/0x440
Fixes: b6bc41645547 ("watchdog: of_xilinx_wdt: Add support for reading freq via CCF")
Signed-off-by: Srinivas Neeli <srinivas.neeli@amd.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Link: https://lore.kernel.org/r/20230901070929.1317982-1-ruanjinjie@huawei.com
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Wim Van Sebroeck <wim@linux-watchdog.org>
Diffstat (limited to 'drivers/watchdog/marvell_gti_wdt.c')
0 files changed, 0 insertions, 0 deletions