diff options
| author | Anand Jain <anand.jain@oracle.com> | 2022-11-10 09:06:31 +0300 |
|---|---|---|
| committer | David Sterba <dsterba@suse.com> | 2022-11-15 19:15:45 +0300 |
| commit | 013c1c5585ebcfb19c88efe79063d0463b1b6159 (patch) | |
| tree | f81b0402626db34d21447d0a9af56e6d281f3fe7 /fs/btrfs/ioctl.c | |
| parent | 8cf96b409d9b3946ece58ced13f92d0f775b0442 (diff) | |
| download | linux-013c1c5585ebcfb19c88efe79063d0463b1b6159.tar.xz | |
btrfs: free btrfs_path before copying subvol info to userspace
btrfs_ioctl_get_subvol_info() frees the search path after the userspace
copy from the temp buffer @subvol_info. This can lead to a lock splat
warning.
Fix this by freeing the path before we copy it to userspace.
CC: stable@vger.kernel.org # 4.19+
Signed-off-by: Anand Jain <anand.jain@oracle.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Diffstat (limited to 'fs/btrfs/ioctl.c')
| -rw-r--r-- | fs/btrfs/ioctl.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c index df5b893494fa..5ba2e810dc6e 100644 --- a/fs/btrfs/ioctl.c +++ b/fs/btrfs/ioctl.c @@ -3105,6 +3105,8 @@ static int btrfs_ioctl_get_subvol_info(struct inode *inode, void __user *argp) } } + btrfs_free_path(path); + path = NULL; if (copy_to_user(argp, subvol_info, sizeof(*subvol_info))) ret = -EFAULT; |