diff options
| author | Yang Jihong <yangjihong1@huawei.com> | 2023-02-27 05:35:08 +0300 |
|---|---|---|
| committer | Peter Zijlstra <peterz@infradead.org> | 2023-04-14 17:08:22 +0300 |
| commit | 15def34e2635ab7e0e96f1bc32e1b69609f14942 (patch) | |
| tree | 6f5eed1a6bf23dca68381cb036c35a57b208010d /arch/x86/events/intel | |
| parent | 872d28001be56b205bd9b3f97cea1571a1bde317 (diff) | |
| download | linux-15def34e2635ab7e0e96f1bc32e1b69609f14942.tar.xz | |
perf/core: Fix hardlockup failure caused by perf throttle
commit e050e3f0a71bf ("perf: Fix broken interrupt rate throttling")
introduces a change in throttling threshold judgment. Before this,
compare hwc->interrupts and max_samples_per_tick, then increase
hwc->interrupts by 1, but this commit reverses order of these two
behaviors, causing the semantics of max_samples_per_tick to change.
In literal sense of "max_samples_per_tick", if hwc->interrupts ==
max_samples_per_tick, it should not be throttled, therefore, the judgment
condition should be changed to "hwc->interrupts > max_samples_per_tick".
In fact, this may cause the hardlockup to fail, The minimum value of
max_samples_per_tick may be 1, in this case, the return value of
__perf_event_account_interrupt function is 1.
As a result, nmi_watchdog gets throttled, which would stop PMU (Use x86
architecture as an example, see x86_pmu_handle_irq).
Fixes: e050e3f0a71b ("perf: Fix broken interrupt rate throttling")
Signed-off-by: Yang Jihong <yangjihong1@huawei.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Link: https://lkml.kernel.org/r/20230227023508.102230-1-yangjihong1@huawei.com
Diffstat (limited to 'arch/x86/events/intel')
0 files changed, 0 insertions, 0 deletions